From f13ee0890b643f2c2eb220290f8374c80605a505 Mon Sep 17 00:00:00 2001 From: Ray Lehtiniemi Date: Tue, 7 Apr 2009 22:14:20 -0600 Subject: [PATCH] Fix a 64-bit segfault in kdenlive To reproduce: - create a new project - create a color clip - add clip to timeline - set an in point on the clip - add the box blur effect The segfault happens because we take the negative of an unsigned integer. This works out to a signed 32 bit value on a 64 bit platform, which causes the rgb array bounds to be exceeded. Signed-off-by: Ray Lehtiniemi --- src/modules/kdenlive/filter_boxblur.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/modules/kdenlive/filter_boxblur.c b/src/modules/kdenlive/filter_boxblur.c index f2316d0..f1d5425 100644 --- a/src/modules/kdenlive/filter_boxblur.c +++ b/src/modules/kdenlive/filter_boxblur.c @@ -26,7 +26,7 @@ #include -static void PreCompute(uint8_t *yuv, int32_t *rgb, unsigned int width, unsigned int height) +static void PreCompute(uint8_t *yuv, int32_t *rgb, int width, int height) { register int x, y, z; register int uneven = width % 2; -- 1.7.4.4