X-Git-Url: http://research.m1stereo.tv/gitweb?a=blobdiff_plain;f=src%2Fmodules%2Fsdl%2Fconsumer_sdl.c;h=50e08d85611741f911b59ade2bf14d9ad3698c39;hb=cab7cd53c3a4d9c4355751088fec61860dcabbce;hp=962d4ae4ab9fc07b6a0b0ef4f372666220bcd212;hpb=4ee4b9829c53db721194a1983ab5c5054ba766c9;p=melted

diff --git a/src/modules/sdl/consumer_sdl.c b/src/modules/sdl/consumer_sdl.c
index 962d4ae..50e08d8 100644
--- a/src/modules/sdl/consumer_sdl.c
+++ b/src/modules/sdl/consumer_sdl.c
@@ -40,22 +40,28 @@ struct consumer_sdl_s
 	mlt_properties properties;
 	mlt_deque queue;
 	pthread_t thread;
+	int joined;
 	int running;
-	uint8_t audio_buffer[ 4096 * 19 ];
+	uint8_t audio_buffer[ 4096 * 10 ];
 	int audio_avail;
 	pthread_mutex_t audio_mutex;
 	pthread_cond_t audio_cond;
+	pthread_mutex_t video_mutex;
+	pthread_cond_t video_cond;
 	int window_width;
 	int window_height;
 	float aspect_ratio;
+	float display_aspect;
+	double last_frame_aspect;
 	int width;
 	int height;
 	int playing;
 	int sdl_flags;
 	SDL_Surface *sdl_screen;
 	SDL_Overlay *sdl_overlay;
+	SDL_Rect rect;
 	uint8_t *buffer;
-	int time_taken;
+	int bpp;
 };
 
 /** Forward references to static functions.
@@ -67,6 +73,7 @@ static int consumer_is_stopped( mlt_consumer parent );
 static void consumer_close( mlt_consumer parent );
 static void *consumer_thread( void * );
 static int consumer_get_dimensions( int *width, int *height );
+static void consumer_sdl_event( mlt_listener listener, mlt_properties owner, mlt_service this, void **args );
 
 /** This is what will be called by the factory - anything can be passed in
 	via the argument, but keep it simple.
@@ -90,8 +97,8 @@ mlt_consumer consumer_sdl_init( char *arg )
 		parent->close = consumer_close;
 
 		// get a handle on properties
-		mlt_service service = mlt_consumer_service( parent );
-		this->properties = mlt_service_properties( service );
+		mlt_service service = MLT_CONSUMER_SERVICE( parent );
+		this->properties = MLT_SERVICE_PROPERTIES( service );
 
 		// Set the default volume
 		mlt_properties_set_double( this->properties, "volume", 1.0 );
@@ -99,18 +106,29 @@ mlt_consumer consumer_sdl_init( char *arg )
 		// This is the initialisation of the consumer
 		pthread_mutex_init( &this->audio_mutex, NULL );
 		pthread_cond_init( &this->audio_cond, NULL);
+		pthread_mutex_init( &this->video_mutex, NULL );
+		pthread_cond_init( &this->video_cond, NULL);
 		
 		// Default scaler (for now we'll use nearest)
 		mlt_properties_set( this->properties, "rescale", "nearest" );
 
 		// Default buffer for low latency
-		mlt_properties_set_int( this->properties, "buffer", 8 );
+		mlt_properties_set_int( this->properties, "buffer", 1 );
 
 		// Default progressive true
-		mlt_properties_set_int( this->properties, "progressive", 1 );
+		mlt_properties_set_int( this->properties, "progressive", 0 );
 
-		// Get aspect ratio
+		// Default audio buffer
+		mlt_properties_set_int( this->properties, "audio_buffer", 512 );
+
+		// Get sample aspect ratio
 		this->aspect_ratio = mlt_properties_get_double( this->properties, "aspect_ratio" );
+
+		// Ensure we don't join on a non-running object
+		this->joined = 1;
+		
+		// Default display aspect ratio
+		this->display_aspect = 4.0 / 3.0;
 		
 		// process actual param
 		if ( arg == NULL || sscanf( arg, "%dx%d", &this->width, &this->height ) != 2 )
@@ -118,19 +136,22 @@ mlt_consumer consumer_sdl_init( char *arg )
 			this->width = mlt_properties_get_int( this->properties, "width" );
 			this->height = mlt_properties_get_int( this->properties, "height" );
 		}
-		
+
 		// Default window size
-		this->window_width = (int)( (float)this->height * 4.0/3.0 + 0.5);
+		this->window_width = ( float )this->height * this->display_aspect;
 		this->window_height = this->height;
-		
+
 		// Set the sdl flags
-		this->sdl_flags = SDL_HWSURFACE | SDL_ASYNCBLIT | SDL_HWACCEL | SDL_RESIZABLE;
+		this->sdl_flags = SDL_HWSURFACE | SDL_ASYNCBLIT | SDL_HWACCEL | SDL_RESIZABLE | SDL_DOUBLEBUF;
 
 		// Allow thread to be started/stopped
 		parent->start = consumer_start;
 		parent->stop = consumer_stop;
 		parent->is_stopped = consumer_is_stopped;
 
+		// Register specific events
+		mlt_events_register( this->properties, "consumer-sdl-event", ( mlt_transmitter )consumer_sdl_event );
+
 		// Return the consumer produced
 		return parent;
 	}
@@ -142,14 +163,37 @@ mlt_consumer consumer_sdl_init( char *arg )
 	return NULL;
 }
 
+static void consumer_sdl_event( mlt_listener listener, mlt_properties owner, mlt_service this, void **args )
+{
+	if ( listener != NULL )
+		listener( owner, this, ( SDL_Event * )args[ 0 ] );
+}
+
 int consumer_start( mlt_consumer parent )
 {
 	consumer_sdl this = parent->child;
 
 	if ( !this->running )
 	{
+		pthread_attr_t thread_attributes;
+		
+		consumer_stop( parent );
+
 		this->running = 1;
-		pthread_create( &this->thread, NULL, consumer_thread, this );
+		this->joined = 0;
+
+		// Allow the user to force resizing to window size
+		if ( mlt_properties_get_int( this->properties, "resize" ) )
+		{
+			mlt_properties_set_int( this->properties, "width", this->width );
+			mlt_properties_set_int( this->properties, "height", this->height );
+		}
+
+		// Inherit the scheduling priority
+		pthread_attr_init( &thread_attributes );
+		pthread_attr_setinheritsched( &thread_attributes, PTHREAD_INHERIT_SCHED );
+
+		pthread_create( &this->thread, &thread_attributes, consumer_thread, this );
 	}
 
 	return 0;
@@ -160,15 +204,11 @@ int consumer_stop( mlt_consumer parent )
 	// Get the actual object
 	consumer_sdl this = parent->child;
 
-	if ( this->running )
+	if ( this->joined == 0 )
 	{
 		// Kill the thread and clean up
+		this->joined = 1;
 		this->running = 0;
-
-		pthread_mutex_lock( &this->audio_mutex );
-		pthread_cond_broadcast( &this->audio_cond );
-		pthread_mutex_unlock( &this->audio_mutex );
-
 		pthread_join( this->thread, NULL );
 	}
 
@@ -210,7 +250,7 @@ static void sdl_fill_audio( void *udata, uint8_t *stream, int len )
 	if ( this->audio_avail >= len )
 	{
 		// Place in the audio buffer
-		SDL_MixAudio( stream, this->audio_buffer, len, ( int )( ( float )SDL_MIX_MAXVOLUME * volume ) );
+		memcpy( stream, this->audio_buffer, len );
 
 		// Remove len from the audio available
 		this->audio_avail -= len;
@@ -247,11 +287,9 @@ static int consumer_play_audio( consumer_sdl this, mlt_frame frame, int init_aud
 	mlt_audio_format afmt = mlt_audio_pcm;
 
 	// Set the preferred params of the test card signal
-	int channels = 2;
-	int frequency = 48000;
+	int channels = mlt_properties_get_int( properties, "channels" );
+	int frequency = mlt_properties_get_int( properties, "frequency" );
 	static int counter = 0;
-	if ( mlt_properties_get_int( properties, "frequency" ) != 0 )
-		frequency =  mlt_properties_get_int( properties, "frequency" );
 
 	int samples = mlt_sample_calculator( mlt_properties_get_double( this->properties, "fps" ), frequency, counter++ );
 	
@@ -264,6 +302,7 @@ static int consumer_play_audio( consumer_sdl this, mlt_frame frame, int init_aud
 	if ( mlt_properties_get_int( properties, "audio_off" ) )
 	{
 		this->playing = 1;
+		init_audio = 1;
 		return init_audio;
 	}
 
@@ -272,13 +311,15 @@ static int consumer_play_audio( consumer_sdl this, mlt_frame frame, int init_aud
 		SDL_AudioSpec request;
 		SDL_AudioSpec got;
 
+		int audio_buffer = mlt_properties_get_int( properties, "audio_buffer" );
+
 		// specify audio format
 		memset( &request, 0, sizeof( SDL_AudioSpec ) );
 		this->playing = 0;
 		request.freq = frequency;
 		request.format = AUDIO_S16;
 		request.channels = channels;
-		request.samples = 1024;
+		request.samples = audio_buffer;
 		request.callback = sdl_fill_audio;
 		request.userdata = (void *)this;
 		if ( SDL_OpenAudio( &request, &got ) != 0 )
@@ -295,16 +336,19 @@ static int consumer_play_audio( consumer_sdl this, mlt_frame frame, int init_aud
 
 	if ( init_audio == 0 )
 	{
+		mlt_properties properties = MLT_FRAME_PROPERTIES( frame );
 		bytes = ( samples * channels * 2 );
 		pthread_mutex_lock( &this->audio_mutex );
-		while ( bytes > ( sizeof( this->audio_buffer) - this->audio_avail ) )
+		while ( this->running && bytes > ( sizeof( this->audio_buffer) - this->audio_avail ) )
 			pthread_cond_wait( &this->audio_cond, &this->audio_mutex );
-		mlt_properties properties = mlt_frame_properties( frame );
-		if ( mlt_properties_get_double( properties, "_speed" ) == 1 )
-			memcpy( &this->audio_buffer[ this->audio_avail ], pcm, bytes );
-		else
-			memset( &this->audio_buffer[ this->audio_avail ], 0, bytes );
-		this->audio_avail += bytes;
+		if ( this->running )
+		{
+			if ( mlt_properties_get_double( properties, "_speed" ) == 1 )
+				memcpy( &this->audio_buffer[ this->audio_avail ], pcm, bytes );
+			else
+				memset( &this->audio_buffer[ this->audio_avail ], 0, bytes );
+			this->audio_avail += bytes;
+		}
 		pthread_cond_broadcast( &this->audio_cond );
 		pthread_mutex_unlock( &this->audio_mutex );
 	}
@@ -316,7 +360,7 @@ static int consumer_play_audio( consumer_sdl this, mlt_frame frame, int init_aud
 	return init_audio;
 }
 
-static int consumer_play_video( consumer_sdl this, mlt_frame frame, int64_t elapsed, int64_t playtime )
+static int consumer_play_video( consumer_sdl this, mlt_frame frame )
 {
 	// Get the properties of this consumer
 	mlt_properties properties = this->properties;
@@ -326,38 +370,23 @@ static int consumer_play_video( consumer_sdl this, mlt_frame frame, int64_t elap
 	uint8_t *image;
 	int changed = 0;
 
-	if ( mlt_properties_get_int( properties, "video_off" ) )
+	if ( this->running && mlt_properties_get_int( properties, "video_off" ) == 0 )
 	{
-		mlt_frame_close( frame );
-		return 0;
-	}
-
-	// Set skip
-	mlt_properties_set_position( mlt_frame_properties( frame ), "playtime", playtime );
-
-	// Push this frame to the back of the queue
-	mlt_deque_push_back( this->queue, frame );
-	frame = NULL;
-
-	if ( this->playing )
-		frame = mlt_deque_pop_front( this->queue );
-
-	if ( this->playing && frame != NULL && mlt_properties_get_int( mlt_frame_properties( frame ), "rendered" ) == 1 )
-	{
-		playtime = mlt_properties_get_position( mlt_frame_properties( frame ), "playtime" );
-
 		// Get the image, width and height
+		mlt_events_fire( properties, "consumer-frame-show", frame, NULL );
 		mlt_frame_get_image( frame, &image, &vfmt, &width, &height, 0 );
-
+		
 		// Handle events
 		if ( this->sdl_screen != NULL )
 		{
 			SDL_Event event;
 	
 			changed = consumer_get_dimensions( &this->window_width, &this->window_height );
-	
+
 			while ( SDL_PollEvent( &event ) )
 			{
+				mlt_events_fire( this->properties, "consumer-sdl-event", &event, NULL );
+
 				switch( event.type )
 				{
 					case SDL_VIDEORESIZE:
@@ -365,6 +394,9 @@ static int consumer_play_video( consumer_sdl this, mlt_frame frame, int64_t elap
 						this->window_height = event.resize.h;
 						changed = 1;
 						break;
+					case SDL_QUIT:
+						this->running = 0;
+						break;
 					case SDL_KEYDOWN:
 						{
 							mlt_producer producer = mlt_properties_get_data( properties, "transport_producer", NULL );
@@ -383,87 +415,216 @@ static int consumer_play_video( consumer_sdl this, mlt_frame frame, int64_t elap
 	
 		if ( width != this->width || height != this->height )
 		{
-			this->width = width;
-			this->height = height;
-			changed = 1;
+			if ( this->sdl_overlay != NULL )
+				SDL_FreeYUVOverlay( this->sdl_overlay );
+			this->sdl_overlay = NULL;
 		}
 
-		if ( this->sdl_screen == NULL || changed )
+		if ( this->running && ( this->sdl_screen == NULL || changed ) )
 		{
-			double aspect_ratio = ( float )this->aspect_ratio * this->width / this->height;
-			float display_aspect_ratio = ( float )width / height;
-			SDL_Rect rect;
-			if ( mlt_properties_get( properties, "rescale" ) != NULL &&
-					!strcmp( mlt_properties_get( properties, "rescale" ), "none" ) )
-				aspect_ratio = mlt_frame_get_aspect_ratio( frame ) * mlt_properties_get_int(mlt_frame_properties(frame),"width") / mlt_properties_get_int(mlt_frame_properties(frame),"height");
+			// Force an overlay recreation
+			if ( this->sdl_overlay != NULL )
+				SDL_FreeYUVOverlay( this->sdl_overlay );
+			this->sdl_overlay = NULL;
+
+			// open SDL window with video overlay, if possible
+			sdl_lock_display();
+			this->sdl_screen = SDL_SetVideoMode( this->window_width, this->window_height, this->bpp, this->sdl_flags );
+			sdl_unlock_display();
+			if ( consumer_get_dimensions( &this->window_width, &this->window_height ) )
+				this->sdl_screen = SDL_SetVideoMode( this->window_width, this->window_height, this->bpp, this->sdl_flags );
+			//SDL_Flip( this->sdl_screen );
+			mlt_properties_set_int( properties, "changed", 0 );
+		}
+		else if ( mlt_properties_get_int( properties, "changed" ) )
+		{
+			sdl_lock_display();
+			this->sdl_screen = SDL_SetVideoMode( this->window_width, this->window_height, this->bpp, this->sdl_flags );
+			SDL_SetClipRect( this->sdl_screen, &this->rect );
+			sdl_unlock_display();
+			mlt_properties_set_int( properties, "changed", 0 );
+		}
+
+		if ( this->running )
+		{
+			// Determine window's new display aspect ratio
+			float this_aspect = ( float )this->window_width / this->window_height;
 
-			if ( aspect_ratio == 1 )
+			// Determine frame's display aspect ratio
+			float frame_aspect = mlt_frame_get_aspect_ratio( frame ) * width / height;
+			this->width = width;
+			this->height = height;
+
+			// If using hardware scaler
+			if ( mlt_properties_get( properties, "rescale" ) != NULL &&
+				!strcmp( mlt_properties_get( properties, "rescale" ), "none" ) )
 			{
-				rect.w = this->window_width;
-				rect.h = this->window_height;
+				// Special case optimisation to negate odd effect of sample aspect ratio
+				// not corresponding exactly with image resolution.
+				if ( ( (int)( this_aspect * 1000 ) == (int)( this->display_aspect * 1000 ) ) && 
+					 ( (int)( mlt_frame_get_aspect_ratio( frame ) * 1000 ) == (int)( this->aspect_ratio * 1000 ) ) )
+				{
+					this->rect.w = this->window_width;
+					this->rect.h = this->window_height;
+				}
+				else
+				{
+					// Use hardware scaler to normalise display aspect ratio
+					this->rect.w = frame_aspect / this_aspect * this->window_width;
+					this->rect.h = this->window_height;
+					if ( this->rect.w > this->window_width )
+					{
+						this->rect.w = this->window_width;
+						this->rect.h = this_aspect / frame_aspect * this->window_height;
+					}
+				}
 			}
-			else if ( this->window_width < this->window_height * aspect_ratio )
+			// Special case optimisation to negate odd effect of sample aspect ratio
+			// not corresponding exactly with image resolution.
+			else if ( (int)( this_aspect * 1000 ) == (int)( this->display_aspect * 1000 ) ) 
 			{
-				rect.w = this->window_width;
-				rect.h = this->window_width / aspect_ratio + 1;
+				this->rect.w = this->window_width;
+				this->rect.h = this->window_height;
 			}
-			else
+			// Use hardware scaler to normalise sample aspect ratio
+			else if ( this->window_height * this->display_aspect > this->window_width )
 			{
-				rect.w = this->window_height * aspect_ratio + 1;
-				rect.h = this->window_height;
+				this->rect.w = this->window_width;
+				this->rect.h = this->window_width / this->display_aspect;
 			}
-
-			if ( mlt_properties_get_int( properties, "scale_overlay" ) )
+			else
 			{
-				if ( ( float )rect.w * display_aspect_ratio < this->window_width )
-					rect.w = ( int )( ( float )rect.w * display_aspect_ratio );
-				else if ( ( float )rect.h * display_aspect_ratio < this->window_height )
-					rect.h = ( int )( ( float )rect.h * display_aspect_ratio );
+				this->rect.w = this->window_height * this->display_aspect;
+				this->rect.h = this->window_height;
 			}
+			
+			this->rect.x = ( this->window_width - this->rect.w ) / 2;
+			this->rect.y = ( this->window_height - this->rect.h ) / 2;
 
-			rect.x = ( this->window_width - rect.w ) / 2;
-			rect.y = ( this->window_height - rect.h ) / 2;
+			mlt_properties_set_int( this->properties, "rect_x", this->rect.x );
+			mlt_properties_set_int( this->properties, "rect_y", this->rect.y );
+			mlt_properties_set_int( this->properties, "rect_w", this->rect.w );
+			mlt_properties_set_int( this->properties, "rect_h", this->rect.h );
 
-			// Force an overlay recreation
-			if ( this->sdl_overlay != NULL )
-				SDL_FreeYUVOverlay( this->sdl_overlay );
-
-			// open SDL window with video overlay, if possible
-			this->sdl_screen = SDL_SetVideoMode( this->window_width, this->window_height, 0, this->sdl_flags );
+			SDL_SetClipRect( this->sdl_screen, &this->rect );
+		}
 
-			if ( this->sdl_screen != NULL )
-			{
-				SDL_SetClipRect( this->sdl_screen, &rect );
-			
-				sdl_lock_display();
-				this->sdl_overlay = SDL_CreateYUVOverlay( this->width - (this->width % 4), this->height- (this->height % 2 ), SDL_YUY2_OVERLAY, this->sdl_screen );
-				sdl_unlock_display();
-			}
+		if ( this->running && this->sdl_screen != NULL && this->sdl_overlay == NULL )
+		{
+			SDL_SetClipRect( this->sdl_screen, &this->rect );
+			SDL_Flip( this->sdl_screen );
+			sdl_lock_display();
+			this->sdl_overlay = SDL_CreateYUVOverlay( this->width, this->height, SDL_YUY2_OVERLAY, this->sdl_screen );
+			sdl_unlock_display();
 		}
-			
-		if ( this->sdl_screen != NULL && this->sdl_overlay != NULL )
+
+		if ( this->running && this->sdl_screen != NULL && this->sdl_overlay != NULL )
 		{
 			this->buffer = this->sdl_overlay->pixels[ 0 ];
+			sdl_lock_display();
 			if ( SDL_LockYUVOverlay( this->sdl_overlay ) >= 0 )
 			{
-				memcpy( this->buffer, image, width * height * 2 );
+				if ( image != NULL )
+					memcpy( this->buffer, image, width * height * 2 );
 				SDL_UnlockYUVOverlay( this->sdl_overlay );
 				SDL_DisplayYUVOverlay( this->sdl_overlay, &this->sdl_screen->clip_rect );
 			}
+			sdl_unlock_display();
 		}
+	}
+
+	return 0;
+}
+
+static void *video_thread( void *arg )
+{
+	// Identify the arg
+	consumer_sdl this = arg;
 
-		if ( playtime > elapsed + 25000 )
+	// Obtain time of thread start
+	struct timeval now;
+	int64_t start = 0;
+	int64_t elapsed = 0;
+	struct timespec tm;
+	mlt_frame next = NULL;
+	mlt_properties properties = NULL;
+	double speed = 0;
+
+	// Get real time flag
+	int real_time = mlt_properties_get_int( this->properties, "real_time" );
+
+	// Get the current time
+	gettimeofday( &now, NULL );
+
+	// Determine start time
+	start = ( int64_t )now.tv_sec * 1000000 + now.tv_usec;
+
+	while ( this->running )
+	{
+		// Pop the next frame
+		pthread_mutex_lock( &this->video_mutex );
+		next = mlt_deque_pop_front( this->queue );
+		while ( next == NULL && this->running )
 		{
-			struct timespec tm = { ( playtime - elapsed ) / 1000000, ( ( playtime - elapsed ) % 1000000 ) * 1000 };
-			nanosleep( &tm, NULL );
+			pthread_cond_wait( &this->video_cond, &this->video_mutex );
+			next = mlt_deque_pop_front( this->queue );
 		}
+		pthread_mutex_unlock( &this->video_mutex );
+
+		if ( !this->running || next == NULL ) break;
+
+		// Get the properties
+		properties =  MLT_FRAME_PROPERTIES( next );
+
+		// Get the speed of the frame
+		speed = mlt_properties_get_double( properties, "_speed" );
+
+		// Get the current time
+		gettimeofday( &now, NULL );
+
+		// Get the elapsed time
+		elapsed = ( ( int64_t )now.tv_sec * 1000000 + now.tv_usec ) - start;
+
+		// See if we have to delay the display of the current frame
+		if ( mlt_properties_get_int( properties, "rendered" ) == 1 && this->running )
+		{
+			// Obtain the scheduled playout time
+			mlt_position scheduled = mlt_properties_get_position( properties, "playtime" );
+
+			// Determine the difference between the elapsed time and the scheduled playout time
+			mlt_position difference = scheduled - elapsed;
+
+			// Smooth playback a bit
+			if ( real_time && ( difference > 20000 && speed == 1.0 ) )
+			{
+				tm.tv_sec = difference / 1000000;
+				tm.tv_nsec = ( difference % 1000000 ) * 500;
+				nanosleep( &tm, NULL );
+			}
+
+			// Show current frame if not too old
+			if ( !real_time || ( difference > -10000 || speed != 1.0 || mlt_deque_count( this->queue ) < 2 ) )
+				consumer_play_video( this, next );
+
+			// If the queue is empty, recalculate start to allow build up again
+			if ( real_time && ( mlt_deque_count( this->queue ) == 0 && speed == 1.0 ) )
+			{
+				gettimeofday( &now, NULL );
+				start = ( ( int64_t )now.tv_sec * 1000000 + now.tv_usec ) - scheduled + 20000;
+			}
+		}
+
+		// This frame can now be closed
+		mlt_frame_close( next );
+		next = NULL;
 	}
 
-	// Close the frame
-	if ( frame != NULL )
-		mlt_frame_close( frame );
+	if ( next != NULL )
+		mlt_frame_close( next );
 
-	return 0;
+	mlt_consumer_stopped( &this->parent );
+
+	return NULL;
 }
 
 /** Threaded wrapper for pipe.
@@ -477,62 +638,104 @@ static void *consumer_thread( void *arg )
 	// Get the consumer
 	mlt_consumer consumer = &this->parent;
 
+	// Video thread
+	pthread_t thread;
+
 	// internal intialization
 	int init_audio = 1;
-
-	// Obtain time of thread start
-	struct timeval now;
-	int64_t start = 0;
-	int64_t elapsed = 0;
+	int init_video = 1;
+	mlt_frame frame = NULL;
+	mlt_properties properties = NULL;
 	int duration = 0;
 	int64_t playtime = 0;
+	struct timespec tm = { 0, 100000 };
 
-	if ( SDL_Init( SDL_INIT_VIDEO | SDL_INIT_AUDIO | SDL_INIT_NOPARACHUTE ) < 0 )
+	this->bpp = mlt_properties_get_int( this->properties, "bpp" );
+
+	if ( mlt_properties_get_int( MLT_CONSUMER_PROPERTIES( consumer ), "sdl_started" ) == 0 )
 	{
-		fprintf( stderr, "Failed to initialize SDL: %s\n", SDL_GetError() );
-		return NULL;
+		if ( SDL_Init( SDL_INIT_VIDEO | SDL_INIT_NOPARACHUTE ) < 0 )
+		{
+			fprintf( stderr, "Failed to initialize SDL: %s\n", SDL_GetError() );
+			return NULL;
+		}
+
+		SDL_EnableKeyRepeat( SDL_DEFAULT_REPEAT_DELAY, SDL_DEFAULT_REPEAT_INTERVAL );
+		SDL_EnableUNICODE( 1 );
+	}
+	else
+	{
+		if ( SDL_GetVideoSurface( ) != NULL )
+		{
+			this->sdl_screen = SDL_GetVideoSurface( );
+			consumer_get_dimensions( &this->window_width, &this->window_height );
+			mlt_properties_set_int( this->properties, "changed", 0 );
+		}
 	}
 
-	SDL_EnableKeyRepeat( SDL_DEFAULT_REPEAT_DELAY, SDL_DEFAULT_REPEAT_INTERVAL );
-	SDL_EnableUNICODE( 1 );
+	if ( !mlt_properties_get_int( MLT_CONSUMER_PROPERTIES( consumer ), "audio_off" ) )
+		SDL_InitSubSystem( SDL_INIT_AUDIO );
 
 	// Loop until told not to
 	while( this->running )
 	{
 		// Get a frame from the attached producer
-		mlt_frame frame = mlt_consumer_rt_frame( consumer );
+		frame = mlt_consumer_rt_frame( consumer );
 
 		// Ensure that we have a frame
 		if ( frame != NULL )
 		{
+			// Get the frame properties
+			properties =  MLT_FRAME_PROPERTIES( frame );
+
 			// Play audio
 			init_audio = consumer_play_audio( this, frame, init_audio, &duration );
 
-			if ( this->playing )
+			// Determine the start time now
+			if ( this->playing && init_video )
 			{
-				// Get the current time
-				gettimeofday( &now, NULL );
-
-				// Determine elapsed time
-				if ( start == 0 )
-					start = ( int64_t )now.tv_sec * 1000000 + now.tv_usec;
-				else
-					elapsed = ( ( int64_t )now.tv_sec * 1000000 + now.tv_usec) - start;
+				// Create the video thread
+				pthread_create( &thread, NULL, video_thread, this );
 
+				// Video doesn't need to be initialised any more
+				init_video = 0;
 			}
 
-			consumer_play_video( this, frame, elapsed, playtime );
+			// Set playtime for this frame
+			mlt_properties_set_position( properties, "playtime", playtime );
+
+			while ( this->running && mlt_deque_count( this->queue ) > 15 )
+				nanosleep( &tm, NULL );
 
+			// Push this frame to the back of the queue
+			pthread_mutex_lock( &this->video_mutex );
+			mlt_deque_push_back( this->queue, frame );
+			pthread_cond_broadcast( &this->video_cond );
+			pthread_mutex_unlock( &this->video_mutex );
+
+			// Calculate the next playtime
 			playtime += ( duration * 1000 );
 		}
 	}
 
+	// Kill the video thread
+	if ( init_video == 0 )
+	{
+		pthread_mutex_lock( &this->video_mutex );
+		pthread_cond_broadcast( &this->video_cond );
+		pthread_mutex_unlock( &this->video_mutex );
+		pthread_join( thread, NULL );
+	}
+
 	// internal cleanup
-	if ( init_audio == 0 )
-		SDL_AudioQuit( );
 	if ( this->sdl_overlay != NULL )
 		SDL_FreeYUVOverlay( this->sdl_overlay );
-	SDL_Quit( );
+
+	if ( !mlt_properties_get_int( MLT_CONSUMER_PROPERTIES( consumer ), "audio_off" ) )
+		SDL_QuitSubSystem( SDL_INIT_AUDIO );
+
+	//if ( mlt_properties_get_int( MLT_CONSUMER_PROPERTIES( consumer ), "sdl_started" ) == 0 )
+		//SDL_Quit( );
 
 	while( mlt_deque_count( this->queue ) )
 		mlt_frame_close( mlt_deque_pop_back( this->queue ) );
@@ -554,6 +757,9 @@ static int consumer_get_dimensions( int *width, int *height )
 	// Specify the SDL Version
 	SDL_VERSION( &wm.version );
 
+	// Lock the display
+	sdl_lock_display();
+
 	// Get the wm structure
 	if ( SDL_GetWMInfo( &wm ) == 1 )
 	{
@@ -579,6 +785,9 @@ static int consumer_get_dimensions( int *width, int *height )
 		}
 	}
 
+	// Unlock the display
+	sdl_lock_display();
+
 	return changed;
 }
 
@@ -591,15 +800,18 @@ static void consumer_close( mlt_consumer parent )
 	consumer_sdl this = parent->child;
 
 	// Stop the consumer
-	mlt_consumer_stop( parent );
+	///mlt_consumer_stop( parent );
+
+	// Now clean up the rest
+	mlt_consumer_close( parent );
+
+	// Close the queue
+	mlt_deque_close( this->queue );
 
 	// Destroy mutexes
 	pthread_mutex_destroy( &this->audio_mutex );
 	pthread_cond_destroy( &this->audio_cond );
 		
-	// Now clean up the rest
-	mlt_consumer_close( parent );
-
 	// Finally clean up this
 	free( this );
 }