X-Git-Url: http://research.m1stereo.tv/gitweb?a=blobdiff_plain;f=src%2Fmodules%2Fcore%2Ftransition_luma.c;h=f5da57ebe034bfb12ce122453f6fb0ce1682e57e;hb=9b115c18489fdc84e2198fef65e4e444f579ff24;hp=ed7de2eb212202d08d5d66e88edb2f1fe7b52da6;hpb=b9dbda40ec64f1d4f58e7da87125d38aa3ab54d1;p=melted

diff --git a/src/modules/core/transition_luma.c b/src/modules/core/transition_luma.c
index ed7de2e..f5da57e 100644
--- a/src/modules/core/transition_luma.c
+++ b/src/modules/core/transition_luma.c
@@ -78,6 +78,10 @@ static inline int dissolve_yuv( mlt_frame this, mlt_frame that, float weight, in
 	mlt_frame_get_image( this, &p_dest, &format, &width, &height, 1 );
 	mlt_frame_get_image( that, &p_src, &format, &width_src, &height_src, 0 );
 
+	// Pick the lesser of two evils ;-)
+	width_src = width_src > width ? width : width_src;
+	height_src = height_src > height ? height : height_src;
+	
 	p = p_dest;
 	limit = p_dest + height_src * width_src * 2;
 
@@ -92,7 +96,7 @@ static inline int dissolve_yuv( mlt_frame this, mlt_frame that, float weight, in
 
 // image processing functions
 
-static inline uint32_t smoothstep( int32_t edge1, int32_t edge2, uint32_t a )
+static inline int32_t smoothstep( int32_t edge1, int32_t edge2, uint32_t a )
 {
 	if ( a < edge1 )
 		return 0;
@@ -128,6 +132,10 @@ static void luma_composite( mlt_frame a_frame, mlt_frame b_frame, int luma_width
 	mlt_frame_get_image( a_frame, &p_dest, &format_dest, &width_dest, &height_dest, 1 );
 	mlt_frame_get_image( b_frame, &p_src, &format_src, &width_src, &height_src, 0 );
 
+	// Pick the lesser of two evils ;-)
+	width_src = width_src > width_dest ? width_dest : width_src;
+	height_src = height_src > height_dest ? height_dest : height_src;
+	
 	stride_src = width_src * 2;
 	stride_dest = width_dest * 2;
 
@@ -152,10 +160,9 @@ static void luma_composite( mlt_frame a_frame, mlt_frame b_frame, int luma_width
 
 	int32_t i_softness = softness * ( 1 << 16 );
 
-	int field_count = field_order <= 0 ? 1 : 2;
+	int field_count = field_order < 0 ? 1 : 2;
 	int field_stride_src = field_count * stride_src;
 	int field_stride_dest = field_count * stride_dest;
-
 	int field = 0;
 
 	// composite using luma map
@@ -163,7 +170,7 @@ static void luma_composite( mlt_frame a_frame, mlt_frame b_frame, int luma_width
 	{
 		p_row = p_src + field * stride_src;
 		q_row = p_dest + field * stride_dest;
-		y_offset = ( field * luma_width ) << 16;
+		y_offset = field << 16;
 		i = field;
 
 		while ( i < height_src )
@@ -438,12 +445,16 @@ static int transition_get_image( mlt_frame a_frame, uint8_t **image, mlt_image_f
 	float frame_delta = delta_calculate( transition, a_frame );
 	
 	float luma_softness = mlt_properties_get_double( properties, "softness" );
-	int progressive = mlt_properties_get_int( b_props, "progressive" ) ||
+	int progressive = 
 			mlt_properties_get_int( a_props, "consumer_progressive" ) ||
+			mlt_properties_get_int( properties, "progressive" ) ||
 			mlt_properties_get_int( b_props, "luma.progressive" );
 	int top_field_first =  mlt_properties_get_int( b_props, "top_field_first" );
 	int reverse = mlt_properties_get_int( properties, "reverse" );
 
+	if ( mlt_properties_get( a_props, "rescale.interp" ) == NULL )
+		mlt_properties_set( a_props, "rescale.interp", "nearest" );
+
 	// Since we are the consumer of the b_frame, we must pass along this
 	// consumer property from the a_frame
 	if ( !strcmp( mlt_properties_get( a_props, "rescale.interp" ), "none" ) )
@@ -461,6 +472,9 @@ static int transition_get_image( mlt_frame a_frame, uint8_t **image, mlt_image_f
 	// Ensure we get scaling on the b_frame
 	mlt_properties_set( b_props, "rescale.interp", "nearest" );
 
+	if ( mlt_properties_get( properties, "fixed" ) )
+		mix = mlt_properties_get_double( properties, "fixed" );
+
 	if ( luma_width > 0 && luma_height > 0 && luma_bitmap != NULL )
 		// Composite the frames using a luma map
 		luma_composite( a_frame, b_frame, luma_width, luma_height, luma_bitmap, mix, frame_delta,