X-Git-Url: http://research.m1stereo.tv/gitweb?a=blobdiff_plain;f=src%2Fframework%2Fmlt_filter.c;h=37f91db3b8ed7cbd63660b0a907fb42d586fcb98;hb=091e9065c24ede24d42c2a473a9c6f1e6d837f47;hp=95dfc5aa8759a1faebc9374eaccbe255135d3524;hpb=05ddafbb9518251a354d2d947cf5c8d109c76909;p=melted

diff --git a/src/framework/mlt_filter.c b/src/framework/mlt_filter.c
index 95dfc5a..37f91db 100644
--- a/src/framework/mlt_filter.c
+++ b/src/framework/mlt_filter.c
@@ -44,25 +44,42 @@ int mlt_filter_init( mlt_filter this, void *child )
 		// Override the get_frame method
 		service->get_frame = filter_get_frame;
 
+		// Define the destructor
+		service->close = ( mlt_destructor )mlt_filter_close;
+		service->close_object = this;
+
 		// Default in, out, track properties
 		mlt_properties_set_position( properties, "in", 0 );
 		mlt_properties_set_position( properties, "out", 0 );
 		mlt_properties_set_int( properties, "track", 0 );
-		mlt_properties_set( properties, "resource", "<filter>" );
 
 		return 0;
 	}
 	return 1;
 }
 
+/** Create a new filter.
+*/
+
+mlt_filter mlt_filter_new( )
+{
+	mlt_filter this = calloc( 1, sizeof( struct mlt_filter_s ) );
+	if ( this != NULL )
+		mlt_filter_init( this, NULL );
+	return this;
+}
+
 /** Get the service associated to this filter
 */
 
 mlt_service mlt_filter_service( mlt_filter this )
 {
-	return &this->parent;
+	return this != NULL ? &this->parent : NULL;
 }
 
+/** Get the properties associated to this filter.
+*/
+
 mlt_properties mlt_filter_properties( mlt_filter this )
 {
 	return mlt_service_properties( mlt_filter_service( this ) );
@@ -80,7 +97,6 @@ int mlt_filter_connect( mlt_filter this, mlt_service producer, int index )
 	if ( ret == 0 )
 	{
 		mlt_properties properties = mlt_service_properties( &this->parent );
-		this->producer = producer;
 		mlt_properties_set_position( properties, "in", 0 );
 		mlt_properties_set_position( properties, "out", 0 );
 		mlt_properties_set_int( properties, "track", index );
@@ -129,7 +145,7 @@ mlt_position mlt_filter_get_out( mlt_filter this )
 /** Process the frame.
 */
 
-static mlt_frame filter_process( mlt_filter this, mlt_frame frame )
+mlt_frame mlt_filter_process( mlt_filter this, mlt_frame frame )
 {
 	if ( this->process == NULL )
 		return frame;
@@ -149,15 +165,18 @@ static int filter_get_frame( mlt_service service, mlt_frame_ptr frame, int index
 	int in = mlt_filter_get_in( this );
 	int out = mlt_filter_get_out( this );
 	
+	// Get the producer this is connected to
+	mlt_service producer = mlt_service_producer( &this->parent );
+
 	// If the frame request is for this filters track, we need to process it
 	if ( index == track )
 	{
-		int ret = mlt_service_get_frame( this->producer, frame, index );
+		int ret = mlt_service_get_frame( producer, frame, index );
 		if ( ret == 0 )
 		{
 			mlt_position position = mlt_frame_get_position( *frame );
-			if ( position >= in && ( out == 0 || position < out ) )
-				*frame = filter_process( this, *frame );
+			if ( position >= in && ( out == 0 || position <= out ) )
+				*frame = mlt_filter_process( this, *frame );
 			return 0;
 		}
 		else
@@ -168,7 +187,7 @@ static int filter_get_frame( mlt_service service, mlt_frame_ptr frame, int index
 	}
 	else
 	{
-		return mlt_service_get_frame( this->producer, frame, index );
+		return mlt_service_get_frame( producer, frame, index );
 	}
 }
 
@@ -177,9 +196,17 @@ static int filter_get_frame( mlt_service service, mlt_frame_ptr frame, int index
 
 void mlt_filter_close( mlt_filter this )
 {
-	if ( this->close != NULL )
-		this->close( this );
-	else
-		mlt_service_close( &this->parent );
+	if ( this != NULL && mlt_properties_dec_ref( mlt_filter_properties( this ) ) <= 0 )
+	{
+		if ( this->close != NULL )
+		{
+			this->close( this );
+		}
+		else
+		{
+			this->parent.close = NULL;
+			mlt_service_close( &this->parent );
+		}
+		free( this );
+	}
 }
-