// Create the dv_decoder
this->dv_decoder = dv_decoder_new( FALSE, FALSE, FALSE );
- this->dv_decoder->quality = DV_QUALITY_BEST;
+ this->dv_decoder->quality = DV_QUALITY_COLOR | DV_QUALITY_AC_1;
this->dv_decoder->audio->arg_audio_emphasis = 2;
dv_set_audio_correction( this->dv_decoder, DV_AUDIO_CORRECT_AVERAGE );
// Open the file if specified
this->fd = open( filename, O_RDONLY );
- producer_collect_info( this );
- // Set the resource property (required for all producers)
- mlt_properties_set( properties, "resource", filename );
+ // Collect info
+ if ( this->fd != -1 && producer_collect_info( this ) )
+ {
+ // Set the resource property (required for all producers)
+ mlt_properties_set( properties, "resource", filename );
+ }
+ else
+ {
+ // Reject this file
+ mlt_producer_close( producer );
+ producer = NULL;
+ }
// Return the producer
return producer;
static int producer_collect_info( producer_libdv this )
{
int valid = 0;
- uint8_t *dv_data = malloc( frame_size_625_50 );
+
+ uint8_t *dv_data = mlt_pool_alloc( frame_size_625_50 );
if ( dv_data != NULL )
{
// Calculate default in/out points
double fps = this->is_pal ? 25 : 30000.0 / 1001.0;
- mlt_properties_set_double( properties, "fps", fps );
- mlt_properties_set_position( properties, "length", this->frames_in_file );
- mlt_properties_set_position( properties, "in", 0 );
- mlt_properties_set_position( properties, "out", this->frames_in_file - 1 );
+ if ( mlt_properties_get_double( properties, "fps" ) == fps )
+ {
+ mlt_properties_set_position( properties, "length", this->frames_in_file );
+ mlt_properties_set_position( properties, "in", 0 );
+ mlt_properties_set_position( properties, "out", this->frames_in_file - 1 );
+ }
+ else
+ {
+ valid = 0;
+ }
// Parse the header for meta info
dv_parse_header( this->dv_decoder, dv_data );
- mlt_properties_set_double( properties, "aspect_ratio", dv_format_wide( this->dv_decoder ) ? 16.0/9.0 : 4.0/3.0 );
+ mlt_properties_set_double( properties, "aspect_ratio",
+ dv_format_wide( this->dv_decoder ) ? ( this->is_pal ? 512.0/351.0 : 96.0/79.0 ) : ( this->is_pal ? 128.0/117.0 : 72.0/79.0 ) );
}
- free( dv_data );
+ mlt_pool_release( dv_data );
}
return valid;
if ( *format == mlt_image_yuv422 )
{
// Allocate an image
- uint8_t *image = malloc( *width * *height * 2 );
+ uint8_t *image = mlt_pool_alloc( *width * ( *height + 1 ) * 2 );
// Pass to properties for clean up
- mlt_properties_set_data( properties, "image", image, *width * *height * 2, free, NULL );
+ mlt_properties_set_data( properties, "image", image, *width * ( *height + 1 ) * 2, ( mlt_destructor )mlt_pool_release, NULL );
// Decode the image
pitches[ 0 ] = *width * 2;
else if ( *format == mlt_image_rgb24 )
{
// Allocate an image
- uint8_t *image = malloc( *width * *height * 3 );
+ uint8_t *image = mlt_pool_alloc( *width * ( *height + 1 ) * 3 );
// Pass to properties for clean up
- mlt_properties_set_data( properties, "image", image, *width * *height * 3, free, NULL );
+ mlt_properties_set_data( properties, "image", image, *width * ( *height + 1 ) * 3, ( mlt_destructor )mlt_pool_release, NULL );
// Decode the frame
pitches[ 0 ] = 720 * 3;
// Parse the header for meta info
dv_parse_header( decoder, dv_data );
- // Obtain required values
- //fprintf( stderr, "libdv: frequency %d\n", decoder->audio->frequency );
- *frequency = decoder->audio->frequency;
- *samples = decoder->audio->samples_this_frame;
- *channels = decoder->audio->num_channels;
-
- // Create a temporary workspace
- for ( i = 0; i < 4; i++ )
- audio_channels[ i ] = malloc( DV_AUDIO_MAX_SAMPLES * sizeof( int16_t ) );
-
- // Create a workspace for the result
- *buffer = malloc( *channels * DV_AUDIO_MAX_SAMPLES * sizeof( int16_t ) );
-
- // Pass the allocated audio buffer as a property
- mlt_properties_set_data( properties, "audio", *buffer, *channels * DV_AUDIO_MAX_SAMPLES * sizeof( int16_t ), free, NULL );
-
- // Decode the audio
- dv_decode_full_audio( decoder, dv_data, audio_channels );
+ // Check that we have audio
+ if ( decoder->audio->num_channels > 0 )
+ {
+ // Obtain required values
+ *frequency = decoder->audio->frequency;
+ *samples = decoder->audio->samples_this_frame;
+ *channels = decoder->audio->num_channels;
+
+ // Create a temporary workspace
+ for ( i = 0; i < 4; i++ )
+ audio_channels[ i ] = mlt_pool_alloc( DV_AUDIO_MAX_SAMPLES * sizeof( int16_t ) );
- // Interleave the audio
- p = *buffer;
- for ( i = 0; i < *samples; i++ )
- for ( j = 0; j < *channels; j++ )
- *p++ = audio_channels[ j ][ i ];
-
- // Free the temporary work space
- for ( i = 0; i < 4; i++ )
- free( audio_channels[ i ] );
+ // Create a workspace for the result
+ *buffer = mlt_pool_alloc( *channels * DV_AUDIO_MAX_SAMPLES * sizeof( int16_t ) );
+
+ // Pass the allocated audio buffer as a property
+ mlt_properties_set_data( properties, "audio", *buffer, *channels * DV_AUDIO_MAX_SAMPLES * sizeof( int16_t ), ( mlt_destructor )mlt_pool_release, NULL );
+
+ // Decode the audio
+ dv_decode_full_audio( decoder, dv_data, audio_channels );
+
+ // Interleave the audio
+ p = *buffer;
+ for ( i = 0; i < *samples; i++ )
+ for ( j = 0; j < *channels; j++ )
+ *p++ = audio_channels[ j ][ i ];
+
+ // Free the temporary work space
+ for ( i = 0; i < 4; i++ )
+ mlt_pool_release( audio_channels[ i ] );
+ }
+ else
+ {
+ // No audio available on the frame, so get test audio (silence)
+ this->get_audio = NULL;
+ mlt_frame_get_audio( this, buffer, format, frequency, channels, samples );
+ }
return 0;
}
static int producer_get_frame( mlt_producer producer, mlt_frame_ptr frame, int index )
{
producer_libdv this = producer->child;
- uint8_t *data = malloc( frame_size_625_50 );
+ uint8_t *data = mlt_pool_alloc( frame_size_625_50 );
// Obtain the current frame number
uint64_t position = mlt_producer_frame( producer );
mlt_properties_set_data( properties, "dv_decoder", this->dv_decoder, 0, NULL, NULL );
// Pass the dv data
- mlt_properties_set_data( properties, "dv_data", data, frame_size_625_50, free, NULL );
+ mlt_properties_set_data( properties, "dv_data", data, frame_size_625_50, ( mlt_destructor )mlt_pool_release, NULL );
// Update other info on the frame
mlt_properties_set_int( properties, "width", 720 );
mlt_properties_set_int( properties, "height", this->is_pal ? 576 : 480 );
mlt_properties_set_int( properties, "top_field_first", 0 );
+
+ char *quality = mlt_properties_get( mlt_producer_properties( producer ), "quality" );
+ if ( quality != NULL )
+ {
+ if ( strncmp( quality, "fast", 4 ) == 0 )
+ this->dv_decoder->quality = ( DV_QUALITY_COLOR | DV_QUALITY_DC );
+ else if ( strncmp( quality, "best", 4 ) == 0 )
+ this->dv_decoder->quality = ( DV_QUALITY_COLOR | DV_QUALITY_AC_2 );
+ else
+ this->dv_decoder->quality = ( DV_QUALITY_COLOR | DV_QUALITY_AC_1 );
+ }
// Parse the header for meta info
dv_parse_header( this->dv_decoder, data );
mlt_properties_set_int( properties, "progressive", dv_is_progressive( this->dv_decoder ) );
- mlt_properties_set_double( properties, "aspect_ratio", dv_format_wide( this->dv_decoder ) ? 16.0/9.0 : 4.0/3.0 );
+ mlt_properties_set_double( properties, "aspect_ratio",
+ dv_format_wide( this->dv_decoder ) ? ( this->is_pal ? 512.0/351.0 : 96.0/79.0 ) : ( this->is_pal ? 128.0/117.0 : 72.0/79.0 ) );
// Hmm - register audio callback
( *frame )->get_audio = producer_get_audio;
}
else
{
- free( data );
+ mlt_pool_release( data );
}
// Update timecode on the frame we're creating
//dv_decoder_free( this->dv_decoder );
// Close the file
- if ( this->fd != 0 )
+ if ( this->fd > 0 )
close( this->fd );
// Close the parent
// Free the memory
free( this );
}
-
projects / melted / blobdiff