some bugfixes, filter_shape producer, pixbuf takes svg xml, fezzik can take a service...
[melted] / src / modules / core / transition_composite.c
index 4bd3d41..d9c1bf4 100644 (file)
@@ -25,6 +25,7 @@
 #include <stdlib.h>
 #include <ctype.h>
 #include <string.h>
+#include <math.h>
 
 /** Geometry struct.
 */
@@ -125,6 +126,14 @@ static void geometry_calculate( struct geometry_s *output, struct geometry_s *in
        // Search in for position
        struct geometry_s *out = in->next;
 
+       if ( position >= 1.0 )
+       {
+               int section = floor( position );
+               position -= section;
+               if ( section % 2 == 1 )
+                       position = 1.0 - position;
+       }
+
        while ( out->next != NULL )
        {
                if ( position >= in->position && position < out->position )
@@ -139,12 +148,111 @@ static void geometry_calculate( struct geometry_s *output, struct geometry_s *in
        // Calculate this frames geometry
        output->nw = in->nw;
        output->nh = in->nh;
-       output->x = in->x + ( out->x - in->x ) * position + 0.5;
-       output->y = in->y + ( out->y - in->y ) * position + 0.5;
+       output->x = in->x + ( out->x - in->x ) * position;
+       output->y = in->y + ( out->y - in->y ) * position;
        output->w = in->w + ( out->w - in->w ) * position;
        output->h = in->h + ( out->h - in->h ) * position;
        output->mix = in->mix + ( out->mix - in->mix ) * position;
        output->distort = in->distort;
+
+       output->x = ( int )floor( output->x ) & 0xfffffffe;
+       output->w = ( int )floor( output->w ) & 0xfffffffe;
+       output->sw &= 0xfffffffe;
+}
+
+void transition_destroy_keys( void *arg )
+{
+       struct geometry_s *ptr = arg;
+       struct geometry_s *next = NULL;
+
+       while ( ptr != NULL )
+       {
+               next = ptr->next;
+               free( ptr );
+               ptr = next;
+       }
+}
+
+static struct geometry_s *transition_parse_keys( mlt_transition this,  int normalised_width, int normalised_height )
+{
+       // Loop variable for property interrogation
+       int i = 0;
+
+       // Get the properties of the transition
+       mlt_properties properties = mlt_transition_properties( this );
+
+       // Get the in and out position
+       mlt_position in = mlt_transition_get_in( this );
+       mlt_position out = mlt_transition_get_out( this );
+
+       // Create the start
+       struct geometry_s *start = calloc( 1, sizeof( struct geometry_s ) );
+
+       // Create the end (we always need two entries)
+       struct geometry_s *end = calloc( 1, sizeof( struct geometry_s ) );
+
+       // Pointer
+       struct geometry_s *ptr = start;
+
+       // Parse the start property
+       geometry_parse( start, NULL, mlt_properties_get( properties, "start" ), normalised_width, normalised_height );
+
+       // Parse the keys in between
+       for ( i = 0; i < mlt_properties_count( properties ); i ++ )
+       {
+               // Get the name of the property
+               char *name = mlt_properties_get_name( properties, i );
+
+               // Check that it's valid
+               if ( !strncmp( name, "key[", 4 ) )
+               {
+                       // Get the value of the property
+                       char *value = mlt_properties_get_value( properties, i );
+
+                       // Determine the frame number
+                       int frame = atoi( name + 4 );
+
+                       // Determine the position
+                       float position = 0;
+                       
+                       if ( frame >= 0 && frame < ( out - in ) )
+                               position = ( float )frame / ( float )( out - in + 1 );
+                       else if ( frame < 0 && - frame < ( out - in ) )
+                               position = ( float )( out - in + frame ) / ( float )( out - in + 1 );
+
+                       // For now, we'll exclude all keys received out of order
+                       if ( position > ptr->position )
+                       {
+                               // Create a new geometry
+                               struct geometry_s *temp = calloc( 1, sizeof( struct geometry_s ) );
+
+                               // Parse and add to the list
+                               geometry_parse( temp, ptr, value, normalised_width, normalised_height );
+
+                               // Assign the position
+                               temp->position = position;
+
+                               // Allow the next to be appended after this one
+                               ptr = temp;
+                       }
+                       else
+                       {
+                               fprintf( stderr, "Key out of order - skipping %s\n", name );
+                       }
+               }
+       }
+       
+       // Parse the end
+       geometry_parse( end, ptr, mlt_properties_get( properties, "end" ), normalised_width, normalised_height );
+       if ( out > 0 )
+               end->position = ( float )( out - in ) / ( float )( out - in + 1 );
+       else
+               end->position = 1;
+
+       // Assign to properties to ensure we get destroyed
+       mlt_properties_set_data( properties, "geometries", start, 0, transition_destroy_keys, NULL );
+
+       return start;
 }
 
 /** Parse the alignment properties into the geometry.
@@ -170,14 +278,14 @@ static int alignment_parse( char* align )
 
 static void alignment_calculate( struct geometry_s *geometry )
 {
-       geometry->x += ( geometry->w - geometry->sw ) * geometry->halign / 2 + 0.5;
-       geometry->y += ( geometry->h - geometry->sh ) * geometry->valign / 2 + 0.5;
+       geometry->x += ( geometry->w - geometry->sw ) * geometry->halign / 2;
+       geometry->y += ( geometry->h - geometry->sh ) * geometry->valign / 2;
 }
 
 /** Calculate the position for this frame.
 */
 
-static inline float position_calculate( mlt_transition this, mlt_frame frame )
+static float position_calculate( mlt_transition this, mlt_frame frame )
 {
        // Get the in and out position
        mlt_position in = mlt_transition_get_in( this );
@@ -230,12 +338,12 @@ static int composite_yuv( uint8_t *p_dest, int width_dest, int height_dest, int
        int stride_dest = width_dest * bpp;
 
        // Adjust to consumer scale
-       int x = geometry.x * width_dest / geometry.nw + 0.5;
-       int y = geometry.y * height_dest / geometry.nh + 0.5;
+       int x = geometry.x * width_dest / geometry.nw;
+       int y = geometry.y * height_dest / geometry.nh;
+
+       x &= 0xfffffffe;
+       width_src &= 0xfffffffe;
 
-       if ( bpp == 2 )
-               x -= x % 2;
-               
        // optimization points - no work to do
        if ( width_src <= 0 || height_src <= 0 )
                return ret;
@@ -344,11 +452,7 @@ static int get_b_frame_image( mlt_transition this, mlt_frame b_frame, uint8_t **
        int ret = 0;
        mlt_image_format format = mlt_image_yuv422;
 
-       // Initialise the scaled dimensions from the computed
-       geometry->sw = geometry->w;
-       geometry->sh = geometry->h;
-
-       // Compute the dimensioning rectangle
+       // Get the properties objects
        mlt_properties b_props = mlt_frame_properties( b_frame );
        mlt_properties properties = mlt_transition_properties( this );
 
@@ -359,9 +463,16 @@ static int get_b_frame_image( mlt_transition this, mlt_frame b_frame, uint8_t **
                int normalised_height = geometry->h;
                int real_width = get_value( b_props, "real_width", "width" );
                int real_height = get_value( b_props, "real_height", "height" );
+               double input_ar = mlt_frame_get_aspect_ratio( b_frame );
+               double output_ar = mlt_properties_get_double( b_props, "consumer_aspect_ratio" );
                int scaled_width = real_width;
                int scaled_height = real_height;
+               double output_sar = ( double ) geometry->nw / geometry->nh / output_ar;
 
+               // If the output is fat pixels (NTSC) then stretch our input horizontally
+               // derived from: output_sar / input_sar * real_width
+               scaled_width = output_sar * real_height * input_ar;
+                       
                // Now ensure that our images fit in the normalised frame
                if ( scaled_width > normalised_width )
                {
@@ -374,13 +485,22 @@ static int get_b_frame_image( mlt_transition this, mlt_frame b_frame, uint8_t **
                        scaled_height = normalised_height;
                }
 
-               // Now we need to align to the geometry
-               if ( scaled_width <= geometry->w && scaled_height <= geometry->h )
+               // Now apply the fill
+               // TODO: Should combine fill/distort in one property
+               if ( mlt_properties_get( properties, "fill" ) != NULL )
                {
-                       // Save the new scaled dimensions
-                       geometry->sw = scaled_width;
-                       geometry->sh = scaled_height;
+                       scaled_width = ( geometry->w / scaled_width ) * scaled_width;
+                       scaled_height = ( geometry->h / scaled_height ) * scaled_height;
                }
+
+               // Save the new scaled dimensions
+               geometry->sw = scaled_width;
+               geometry->sh = scaled_height;
+       }
+       else
+       {
+               geometry->sw = geometry->w;
+               geometry->sh = geometry->h;
        }
 
        // We want to ensure that we bypass resize now...
@@ -390,8 +510,8 @@ static int get_b_frame_image( mlt_transition this, mlt_frame b_frame, uint8_t **
        alignment_calculate( geometry );
 
        // Adjust to consumer scale
-       int x = geometry->x * *width / geometry->nw + 0.5;
-       int y = geometry->y * *height / geometry->nh + 0.5;
+       int x = geometry->x * *width / geometry->nw;
+       int y = geometry->y * *height / geometry->nh;
        *width = geometry->sw * *width / geometry->nw;
        *height = geometry->sh * *height / geometry->nh;
 
@@ -410,105 +530,108 @@ static int get_b_frame_image( mlt_transition this, mlt_frame b_frame, uint8_t **
 }
 
 
-static uint8_t *transition_get_alpha_mask( mlt_frame this )
+struct geometry_s *composite_calculate( struct geometry_s *result, mlt_transition this, mlt_frame a_frame, float position )
 {
-       // Obtain properties of frame
-       mlt_properties properties = mlt_frame_properties( this );
-
-       // Return the alpha mask
-       return mlt_properties_get_data( properties, "alpha", NULL );
-}
+       // Get the properties from the transition
+       mlt_properties properties = mlt_transition_properties( this );
 
-void transition_destroy_keys( void *arg )
-{
-       struct geometry_s *ptr = arg;
-       struct geometry_s *next = NULL;
+       // Get the properties from the frame
+       mlt_properties a_props = mlt_frame_properties( a_frame );
+       
+       // Structures for geometry
+       struct geometry_s *start = mlt_properties_get_data( properties, "geometries", NULL );
 
-       while ( ptr != NULL )
+       // Now parse the geometries
+       if ( start == NULL )
        {
-               next = ptr->next;
-               free( ptr );
-               ptr = next;
+               // Obtain the normalised width and height from the a_frame
+               int normalised_width = mlt_properties_get_int( a_props, "normalised_width" );
+               int normalised_height = mlt_properties_get_int( a_props, "normalised_height" );
+
+               // Parse the transitions properties
+               start = transition_parse_keys( this, normalised_width, normalised_height );
        }
+
+       // Do the calculation
+       geometry_calculate( result, start, position );
+
+       // Now parse the alignment
+       result->halign = alignment_parse( mlt_properties_get( properties, "halign" ) );
+       result->valign = alignment_parse( mlt_properties_get( properties, "valign" ) );
+
+       return start;
 }
 
-static struct geometry_s *transition_parse_keys( mlt_transition this,  int normalised_width, int normalised_height )
+mlt_frame composite_copy_region( mlt_transition this, mlt_frame a_frame )
 {
-       // Loop variable for property interrogation
-       int i = 0;
+       // Create a frame to return
+       mlt_frame b_frame = mlt_frame_init( );
 
-       // Get the properties of the transition
-       mlt_properties properties = mlt_transition_properties( this );
+       // Get the properties of the a frame
+       mlt_properties a_props = mlt_frame_properties( a_frame );
 
-       // Get the in and out position
-       mlt_position in = mlt_transition_get_in( this );
-       mlt_position out = mlt_transition_get_out( this );
+       // Get the properties of the b frame
+       mlt_properties b_props = mlt_frame_properties( b_frame );
 
-       // Create the start
-       struct geometry_s *start = calloc( 1, sizeof( struct geometry_s ) );
+       // Get the position
+       float position = position_calculate( this, a_frame );
 
-       // Create the end (we always need two entries)
-       struct geometry_s *end = calloc( 1, sizeof( struct geometry_s ) );
+       // Destination image
+       uint8_t *dest = NULL;
 
-       // Pointer
-       struct geometry_s *ptr = start;
+       // Get the image and dimensions
+       uint8_t *image = mlt_properties_get_data( a_props, "image", NULL );
+       int width = mlt_properties_get_int( a_props, "width" );
+       int height = mlt_properties_get_int( a_props, "height" );
 
-       // Parse the start property
-       geometry_parse( start, NULL, mlt_properties_get( properties, "start" ), normalised_width, normalised_height );
+       // Pointers for copy operation
+       uint8_t *p;
+       uint8_t *q;
+       uint8_t *r;
 
-       // Parse the keys in between
-       for ( i = 0; i < mlt_properties_count( properties ); i ++ )
-       {
-               // Get the name of the property
-               char *name = mlt_properties_get_name( properties, i );
+       // Corrdinates
+       int w = 0;
+       int h = 0;
+       int x = 0;
+       int y = 0;
 
-               // Check that it's valid
-               if ( !strncmp( name, "key[", 4 ) )
-               {
-                       // Get the value of the property
-                       char *value = mlt_properties_get_value( properties, i );
+       // Will need to know region to copy
+       struct geometry_s result;
 
-                       // Determine the frame number
-                       int frame = atoi( name + 4 );
+       // Calculate the region now
+       composite_calculate( &result, this, a_frame, position );
 
-                       // Determine the position
-                       float position = 0;
-                       
-                       if ( frame >= 0 && frame < ( out - in ) )
-                               position = ( float )frame / ( float )( out - in + 1 );
-                       else if ( frame < 0 && - frame < ( out - in ) )
-                               position = ( float )( out - in + frame ) / ( float )( out - in + 1 );
+       // Need to scale down to actual dimensions
+       x = result.x * width / result.nw ;
+       y = result.y * height / result.nh;
+       w = result.w * width / result.nw;
+       h = result.h * height / result.nh;
 
-                       // For now, we'll exclude all keys received out of order
-                       if ( position > ptr->position )
-                       {
-                               // Create a new geometry
-                               struct geometry_s *temp = calloc( 1, sizeof( struct geometry_s ) );
+       x &= 0xfffffffe;
+       w &= 0xfffffffe;
 
-                               // Parse and add to the list
-                               geometry_parse( temp, ptr, value, normalised_width, normalised_height );
+       // Now we need to create a new destination image
+       dest = mlt_pool_alloc( w * h * 2 );
 
-                               // Assign the position
-                               temp->position = position;
+       // Copy the region of the image
+       p = image + y * width * 2 + x * 2;
+       q = dest;
+       r = dest + w * h * 2; 
 
-                               // Allow the next to be appended after this one
-                               ptr = temp;
-                       }
-                       else
-                       {
-                               fprintf( stderr, "Key out of order - skipping %s\n", name );
-                       }
-               }
+       while ( q < r )
+       {
+               memcpy( q, p, w * 2 );
+               q += w * 2;
+               p += width * 2;
        }
-       
-       // Parse the end
-       geometry_parse( end, ptr, mlt_properties_get( properties, "end" ), normalised_width, normalised_height );
-       end->position = ( float )( out - in ) / ( float )( out - in + 1 );
 
-       // Assign to properties to ensure we get destroyed
-       mlt_properties_set_data( properties, "geometries", start, 0, transition_destroy_keys, NULL );
+       // Assign to the new frame
+       mlt_properties_set_data( b_props, "image", dest, w * h * 2, mlt_pool_release, NULL );
+       mlt_properties_set_int( b_props, "width", w );
+       mlt_properties_set_int( b_props, "height", h );
 
-       return start;
+       // Return the frame
+       return b_frame;
 }
 
 /** Get the image.
@@ -519,12 +642,12 @@ static int transition_get_image( mlt_frame a_frame, uint8_t **image, mlt_image_f
        // Get the b frame from the stack
        mlt_frame b_frame = mlt_frame_pop_frame( a_frame );
 
-       // This compositer is yuv422 only
-       *format = mlt_image_yuv422;
-
        // Get the transition from the a frame
        mlt_transition this = mlt_frame_pop_service( a_frame );
 
+       // This compositer is yuv422 only
+       *format = mlt_image_yuv422;
+
        // Get the image from the a frame
        mlt_frame_get_image( a_frame, image, format, width, height, 1 );
 
@@ -541,37 +664,21 @@ static int transition_get_image( mlt_frame a_frame, uint8_t **image, mlt_image_f
 
                // Structures for geometry
                struct geometry_s result;
-               struct geometry_s *start = mlt_properties_get_data( properties, "geometries", NULL );
 
                // Calculate the position
                float position = mlt_properties_get_double( b_props, "relative_position" );
                float delta = delta_calculate( this, a_frame );
 
-               // Now parse the geometries
-               if ( start == NULL )
-               {
-                       // Obtain the normalised width and height from the a_frame
-                       int normalised_width = mlt_properties_get_int( a_props, "normalised_width" );
-                       int normalised_height = mlt_properties_get_int( a_props, "normalised_height" );
-
-                       // Parse the transitions properties
-                       start = transition_parse_keys( this, normalised_width, normalised_height );
-               }
+               // Do the calculation
+               struct geometry_s *start = composite_calculate( &result, this, a_frame, position );
 
                // Since we are the consumer of the b_frame, we must pass along these
                // consumer properties from the a_frame
                mlt_properties_set_double( b_props, "consumer_aspect_ratio", mlt_properties_get_double( a_props, "consumer_aspect_ratio" ) );
                mlt_properties_set_double( b_props, "consumer_scale", mlt_properties_get_double( a_props, "consumer_scale" ) );
 
-               // Do the calculation
-               geometry_calculate( &result, start, position );
-
-               // Now parse the alignment
-               result.halign = alignment_parse( mlt_properties_get( properties, "halign" ) );
-               result.valign = alignment_parse( mlt_properties_get( properties, "valign" ) );
-
                // Get the image from the b frame
-               uint8_t *image_b;
+               uint8_t *image_b = NULL;
                int width_b = *width;
                int height_b = *height;