+ Clean ups and corrections
[melted] / src / modules / core / transition_composite.c
index 4b514e0..b28283d 100644 (file)
@@ -366,87 +366,81 @@ static void luma_read_yuv422( uint8_t *image, uint16_t **map, int width, int hei
                *p++ = ( image[ i ] - 16 ) * 299; // 299 = 65535 / 219
 }
 
+static inline int calculate_mix( uint16_t *luma, int j, int soft, int weight, int alpha )
+{
+       return ( ( ( luma == NULL ) ? weight : smoothstep( luma[ j ], luma[ j ] + soft, weight + soft ) ) * alpha ) >> 8;
+}
+
+static inline uint8_t sample_mix( uint8_t dest, uint8_t src, int mix )
+{
+       return ( src * mix + dest * ( ( 1 << 16 ) - mix ) ) >> 16;
+}
 
 /** Composite a source line over a destination line
 */
 
-static void composite_line_yuv( uint8_t *dest, uint8_t *src, int width, uint8_t *alpha_b, uint8_t *alpha_a,  int weight, uint16_t *luma, int softness )
+static void composite_line_yuv( uint8_t *dest, uint8_t *src, int width, uint8_t *alpha_b, uint8_t *alpha_a, int weight, uint16_t *luma, int soft )
 {
        register int j;
-       register int a;
        register int mix;
-       
+
        for ( j = 0; j < width; j ++ )
        {
-               a = *alpha_b ++;
-               mix = ( luma == NULL ) ? weight : smoothstep( luma[ j ], luma[ j ] + softness, weight + softness );
-               mix = ( mix * a ) >> 8;
-               *dest = ( *src++ * mix + *dest * ( ( 1 << 16 ) - mix ) ) >> 16;
+               mix = calculate_mix( luma, j, soft, weight, *alpha_b ++ );
+               *dest = sample_mix( *dest, *src++, mix );
                dest++;
-               *dest = ( *src++ * mix + *dest * ( ( 1 << 16 ) - mix ) ) >> 16;
+               *dest = sample_mix( *dest, *src++, mix );
                dest++;
                *alpha_a = mix | *alpha_a;
                alpha_a ++;
        }
 }
 
-static void composite_line_yuv_or( uint8_t *dest, uint8_t *src, int width, uint8_t *alpha_b, uint8_t *alpha_a,  int weight, uint16_t *luma, int softness )
+static void composite_line_yuv_or( uint8_t *dest, uint8_t *src, int width, uint8_t *alpha_b, uint8_t *alpha_a, int weight, uint16_t *luma, int soft )
 {
        register int j;
-       register int a;
        register int mix;
-       
+
        for ( j = 0; j < width; j ++ )
        {
-               a = *alpha_b ++ | *alpha_a;
-               mix = ( luma == NULL ) ? weight : smoothstep( luma[ j ], luma[ j ] + softness, weight + softness );
-               mix = ( mix * a ) >> 8;
-               *dest = ( *src++ * mix + *dest * ( ( 1 << 16 ) - mix ) ) >> 16;
+               mix = calculate_mix( luma, j, soft, weight, *alpha_b ++ | *alpha_a );
+               *dest = sample_mix( *dest, *src++, mix );
                dest++;
-               *dest = ( *src++ * mix + *dest * ( ( 1 << 16 ) - mix ) ) >> 16;
+               *dest = sample_mix( *dest, *src++, mix );
                dest++;
-               *alpha_a = mix | *alpha_a;
-               alpha_a ++;
+               *alpha_a ++ = mix;
        }
 }
 
-static void composite_line_yuv_and( uint8_t *dest, uint8_t *src, int width, uint8_t *alpha_b, uint8_t *alpha_a,  int weight, uint16_t *luma, int softness )
+static void composite_line_yuv_and( uint8_t *dest, uint8_t *src, int width, uint8_t *alpha_b, uint8_t *alpha_a, int weight, uint16_t *luma, int soft )
 {
        register int j;
-       register int a;
        register int mix;
-       
+
        for ( j = 0; j < width; j ++ )
        {
-               a = *alpha_b ++ & *alpha_a;
-               mix = ( luma == NULL ) ? weight : smoothstep( luma[ j ], luma[ j ] + softness, weight + softness );
-               mix = ( mix * a ) >> 8;
-               *dest = ( *src++ * mix + *dest * ( ( 1 << 16 ) - mix ) ) >> 16;
+               mix = calculate_mix( luma, j, soft, weight, *alpha_b ++ & *alpha_a );
+               *dest = sample_mix( *dest, *src++, mix );
                dest++;
-               *dest = ( *src++ * mix + *dest * ( ( 1 << 16 ) - mix ) ) >> 16;
+               *dest = sample_mix( *dest, *src++, mix );
                dest++;
-               *alpha_a = mix | *alpha_a;
-               alpha_a ++;
+               *alpha_a ++ = mix;
        }
 }
 
-static void composite_line_yuv_xor( uint8_t *dest, uint8_t *src, int width, uint8_t *alpha_b, uint8_t *alpha_a,  int weight, uint16_t *luma, int softness )
+static void composite_line_yuv_xor( uint8_t *dest, uint8_t *src, int width, uint8_t *alpha_b, uint8_t *alpha_a, int weight, uint16_t *luma, int soft )
 {
        register int j;
-       register int a;
        register int mix;
-       
+
        for ( j = 0; j < width; j ++ )
        {
-               a = *alpha_b ++ ^ *alpha_a;
-               mix = ( luma == NULL ) ? weight : smoothstep( luma[ j ], luma[ j ] + softness, weight + softness );
-               mix = ( mix * a ) >> 8;
-               *dest = ( *src++ * mix + *dest * ( ( 1 << 16 ) - mix ) ) >> 16;
+               mix = calculate_mix( luma, j, soft, weight, *alpha_b ++ ^ *alpha_a );
+               *dest = sample_mix( *dest, *src++, mix );
                dest++;
-               *dest = ( *src++ * mix + *dest * ( ( 1 << 16 ) - mix ) ) >> 16;
+               *dest = sample_mix( *dest, *src++, mix );
                dest++;
-               *alpha_a = mix | *alpha_a;
-               alpha_a ++;
+               *alpha_a ++ = mix;
        }
 }
 
@@ -458,7 +452,7 @@ static int composite_yuv( uint8_t *p_dest, int width_dest, int height_dest, uint
        int ret = 0;
        int i;
        int x_src = 0, y_src = 0;
-       int32_t weight = ( 1 << 16 ) * ( geometry.item.mix / 100 );
+       int32_t weight = ( ( 1 << 16 ) - 1 ) * ( geometry.item.mix / 100 );
        int step = ( field > -1 ) ? 2 : 1;
        int bpp = 2;
        int stride_src = width_src * bpp;
@@ -467,7 +461,7 @@ static int composite_yuv( uint8_t *p_dest, int width_dest, int height_dest, uint
        // Adjust to consumer scale
        int x = rint( 0.5 + geometry.item.x * width_dest / geometry.nw );
        int y = rint( 0.5 + geometry.item.y * height_dest / geometry.nh );
-       int x_uneven = x & 1;
+       int uneven_x = ( x % 2 );
 
        // optimization points - no work to do
        if ( width_src <= 0 || height_src <= 0 )
@@ -540,13 +534,10 @@ static int composite_yuv( uint8_t *p_dest, int width_dest, int height_dest, uint
        int alpha_b_stride = stride_src / bpp;
        int alpha_a_stride = stride_dest / bpp;
 
-       // Make sure than x and w are even
-       if ( x_uneven )
-       {
-               p_src += 2;
-               width_src --;
-               alpha_a ++;
-       }
+       p_src += uneven_x * 2;
+       width_src -= 2 * uneven_x;
+       alpha_b += uneven_x;
+       uneven_x = 0;
 
        // now do the compositing only to cropped extents
        for ( i = 0; i < height_src; i += step )
@@ -733,19 +724,21 @@ static int get_b_frame_image( mlt_transition this, mlt_frame b_frame, uint8_t **
                int real_width = get_value( b_props, "real_width", "width" );
                int real_height = get_value( b_props, "real_height", "height" );
                double input_ar = mlt_properties_get_double( b_props, "aspect_ratio" );
-               double output_ar = mlt_properties_get_double( b_props, "consumer_aspect_ratio" );
-               int scaled_width = ( input_ar == 0.0 ? output_ar : input_ar ) / output_ar * real_width;
+               double consumer_ar = mlt_properties_get_double( b_props, "consumer_aspect_ratio" );
+               double background_ar = mlt_properties_get_double( b_props, "output_ratio" );
+               double output_ar = background_ar != 0.0 ? background_ar : consumer_ar;
+               int scaled_width = rint( 0.5 + ( input_ar == 0.0 ? output_ar : input_ar ) / output_ar * real_width );
                int scaled_height = real_height;
 
                // Now ensure that our images fit in the normalised frame
                if ( scaled_width > normalised_width )
                {
-                       scaled_height = scaled_height * normalised_width / scaled_width;
+                       scaled_height = rint( 0.5 + scaled_height * normalised_width / scaled_width );
                        scaled_width = normalised_width;
                }
                if ( scaled_height > normalised_height )
                {
-                       scaled_width = scaled_width * normalised_height / scaled_height;
+                       scaled_width = rint( 0.5 + scaled_width * normalised_height / scaled_height );
                        scaled_height = normalised_height;
                }
 
@@ -755,12 +748,12 @@ static int get_b_frame_image( mlt_transition this, mlt_frame b_frame, uint8_t **
                {
                        if ( scaled_height < normalised_height && scaled_width * normalised_height / scaled_height < normalised_width )
                        {
-                               scaled_width = scaled_width * normalised_height / scaled_height;
+                               scaled_width = rint( 0.5 + scaled_width * normalised_height / scaled_height );
                                scaled_height = normalised_height;
                        }
                        else if ( scaled_width < normalised_width && scaled_height * normalised_width / scaled_width < normalised_height )
                        {
-                               scaled_height = scaled_height * normalised_width / scaled_width;
+                               scaled_height = rint( 0.5 + scaled_height * normalised_width / scaled_width );
                                scaled_width = normalised_width;
                        }
                }
@@ -776,15 +769,15 @@ static int get_b_frame_image( mlt_transition this, mlt_frame b_frame, uint8_t **
        }
 
        // We want to ensure that we bypass resize now...
-       mlt_properties_set_int( b_props, "distort", 1 );
+       mlt_properties_set_int( b_props, "distort", mlt_properties_get_int( properties, "distort" ) );
 
-       // Take into consideration alignment for optimisation
+       // Take into consideration alignment for optimisation (titles are a special case)
        if ( !mlt_properties_get_int( properties, "titles" ) )
                alignment_calculate( geometry );
 
        // Adjust to consumer scale
-       *width = geometry->sw * *width / geometry->nw;
-       *height = geometry->sh * *height / geometry->nh;
+       *width = rint( 0.5 + geometry->sw * *width / geometry->nw );
+       *height = rint( 0.5 + geometry->sh * *height / geometry->nh );
 
        ret = mlt_frame_get_image( b_frame, image, &format, width, height, 1 );
 
@@ -807,32 +800,43 @@ static mlt_geometry composite_calculate( mlt_transition this, struct geometry_s
        int normalised_width = mlt_properties_get_int( a_props, "normalised_width" );
        int normalised_height = mlt_properties_get_int( a_props, "normalised_height" );
 
-       // Now parse the geometries
-       if ( start == NULL )
-       {
-               // Parse the transitions properties
-               start = transition_parse_keys( this, normalised_width, normalised_height );
+       char *name = mlt_properties_get( properties, "_unique_id" );
+       char key[ 256 ];
 
-               // Assign to properties to ensure we get destroyed
-               mlt_properties_set_data( properties, "geometries", start, 0, ( mlt_destructor )mlt_geometry_close, NULL );
+       sprintf( key, "%s.in", name );
+       if ( mlt_properties_get( a_props, key ) )
+       {
+               sscanf( mlt_properties_get( a_props, key ), "%f,%f,%f,%f,%f,%d,%d", &result->item.x, &result->item.y, &result->item.w, &result->item.h, &result->item.mix, &result->nw, &result->nh );
        }
        else
        {
-               int length = mlt_transition_get_out( this ) - mlt_transition_get_in( this ) + 1;
-               double cycle = mlt_properties_get_double( properties, "cycle" );
-               if ( cycle > 1 )
-                       length = cycle;
-               else if ( cycle > 0 )
-                       length *= cycle;
-               mlt_geometry_refresh( start, mlt_properties_get( properties, "geometry" ), length, normalised_width, normalised_height );
-       }
+               // Now parse the geometries
+               if ( start == NULL )
+               {
+                       // Parse the transitions properties
+                       start = transition_parse_keys( this, normalised_width, normalised_height );
+
+                       // Assign to properties to ensure we get destroyed
+                       mlt_properties_set_data( properties, "geometries", start, 0, ( mlt_destructor )mlt_geometry_close, NULL );
+               }
+               else
+               {
+                       int length = mlt_transition_get_out( this ) - mlt_transition_get_in( this ) + 1;
+                       double cycle = mlt_properties_get_double( properties, "cycle" );
+                       if ( cycle > 1 )
+                               length = cycle;
+                       else if ( cycle > 0 )
+                               length *= cycle;
+                       mlt_geometry_refresh( start, mlt_properties_get( properties, "geometry" ), length, normalised_width, normalised_height );
+               }
 
-       // Do the calculation
-       geometry_calculate( this, result, position );
+               // Do the calculation
+               geometry_calculate( this, result, position );
 
-       // Assign normalised info
-       result->nw = normalised_width;
-       result->nh = normalised_height;
+               // Assign normalised info
+               result->nw = normalised_width;
+               result->nh = normalised_height;
+       }
 
        // Now parse the alignment
        result->halign = alignment_parse( mlt_properties_get( properties, "halign" ) );
@@ -841,16 +845,6 @@ static mlt_geometry composite_calculate( mlt_transition this, struct geometry_s
        return start;
 }
 
-static inline void inline_memcpy( uint8_t *dest, uint8_t *src, int length )
-{
-       uint8_t *end = src + length;
-       while ( src < end )
-       {
-               *dest ++ = *src ++;
-               *dest ++ = *src ++;
-       }
-}
-
 mlt_frame composite_copy_region( mlt_transition this, mlt_frame a_frame, mlt_position frame_position )
 {
        // Create a frame to return
@@ -865,6 +859,10 @@ mlt_frame composite_copy_region( mlt_transition this, mlt_frame a_frame, mlt_pos
        // Get the position
        int position = position_calculate( this, frame_position );
 
+       // Get the unique id of the transition
+       char *name = mlt_properties_get( MLT_TRANSITION_PROPERTIES( this ), "_unique_id" );
+       char key[ 256 ];
+
        // Destination image
        uint8_t *dest = NULL;
 
@@ -889,10 +887,8 @@ mlt_frame composite_copy_region( mlt_transition this, mlt_frame a_frame, mlt_pos
        // Will need to know region to copy
        struct geometry_s result;
 
-       double delta = delta_calculate( this, a_frame, frame_position );
-
        // Calculate the region now
-       composite_calculate( this, &result, a_frame, position + delta / 2 );
+       composite_calculate( this, &result, a_frame, position );
 
        // Need to scale down to actual dimensions
        x = rint( 0.5 + result.item.x * width / result.nw );
@@ -900,19 +896,18 @@ mlt_frame composite_copy_region( mlt_transition this, mlt_frame a_frame, mlt_pos
        w = rint( 0.5 + result.item.w * width / result.nw );
        h = rint( 0.5 + result.item.h * height / result.nh );
 
-       // Make sure that x and w are even
-       if ( x & 1 )
+       if ( x % 2 )
        {
                x --;
-               w += 2;
-               if ( w & 1 )
-                       w --;
-       }
-       else if ( w & 1 )
-       {
                w ++;
        }
 
+       // Store the key
+       sprintf( key, "%s.in=%d,%d,%d,%d,%f,%d,%d", name, x, y, w, h, result.item.mix, width, height );
+       mlt_properties_parse( a_props, key );
+       sprintf( key, "%s.out=%d,%d,%d,%d,%f,%d,%d", name, x, y, w, h, result.item.mix, width, height );
+       mlt_properties_parse( a_props, key );
+
        ds = w * 2;
        ss = width * 2;
 
@@ -949,7 +944,7 @@ mlt_frame composite_copy_region( mlt_transition this, mlt_frame a_frame, mlt_pos
 
                while ( h -- )
                {
-                       inline_memcpy( dest, p, w * 2 );
+                       memcpy( dest, p, w * 2 );
                        dest += ds;
                        p += ss;
                }
@@ -1102,14 +1097,6 @@ static int transition_get_image( mlt_frame a_frame, uint8_t **image, mlt_image_f
 
                        composite_line_fn line_fn = composite_line_yuv;
 
-                       // Silly - this isn't a good solution - deprecating
-                       if ( mlt_properties_get_int( properties, "or" ) )
-                               line_fn = composite_line_yuv_or;
-                       if ( mlt_properties_get_int( properties, "and" ) )
-                               line_fn = composite_line_yuv_and;
-                       if ( mlt_properties_get_int( properties, "xor" ) )
-                               line_fn = composite_line_yuv_xor;
-
                        // Replacement and override
                        if ( operator != NULL )
                        {
@@ -1141,9 +1128,9 @@ static int transition_get_image( mlt_frame a_frame, uint8_t **image, mlt_image_f
 
                                if ( mlt_properties_get_int( properties, "titles" ) )
                                {
-                                       result.item.w = *width * ( result.item.w / result.nw );
+                                       result.item.w = rint( 0.5 + *width * ( result.item.w / result.nw ) );
                                        result.nw = result.item.w;
-                                       result.item.h = *height * ( result.item.h / result.nh );
+                                       result.item.h = rint( 0.5 + *height * ( result.item.h / result.nh ) );
                                        result.nh = *height;
                                        result.sw = width_b;
                                        result.sh = height_b;
@@ -1211,10 +1198,6 @@ mlt_transition transition_composite_init( char *arg )
 
                // Inform apps and framework that this is a video only transition
                mlt_properties_set_int( properties, "_transition_type", 1 );
-
-#ifdef USE_MMX
-               //mlt_properties_set_int( properties, "_MMX", composite_have_mmx() );
-#endif
        }
        return this;
 }