gop size == 0 fix and update to current ffmpeg for cvs co
[melted] / src / modules / avformat / producer_avformat.c
index 1b609f8..ea262d8 100644 (file)
 #include <framework/mlt_frame.h>
 
 // ffmpeg Header files
-#include <ffmpeg/avformat.h>
+#include <avformat.h>
 
 // System header files
 #include <stdlib.h>
 #include <string.h>
+#include <pthread.h>
+#include <math.h>
+
+void avformat_lock( );
+void avformat_unlock( );
 
 // Forward references.
 static int producer_open( mlt_producer this, char *file );
 static int producer_get_frame( mlt_producer this, mlt_frame_ptr frame, int index );
 
-// A static flag used to determine if avformat has been initialised
-static int avformat_initialised = 0;
-
 /** Constructor for libavformat.
 */
 
@@ -60,19 +62,9 @@ mlt_producer producer_avformat_init( char *file )
                        // Set the resource property (required for all producers)
                        mlt_properties_set( properties, "resource", file );
 
-                       // TEST: audio sync tweaking
-                       mlt_properties_set_double( properties, "discrepancy", 1 );
-
                        // Register our get_frame implementation
                        this->get_frame = producer_get_frame;
 
-                       // Initialise avformat if necessary
-                       if ( avformat_initialised == 0 )
-                       {
-                               avformat_initialised = 1;
-                               av_register_all( );
-                       }
-
                        // Open the file
                        if ( producer_open( this, file ) != 0 )
                        {
@@ -89,7 +81,7 @@ mlt_producer producer_avformat_init( char *file )
 /** Find the default streams.
 */
 
-void find_default_streams( AVFormatContext *context, int *audio_index, int *video_index )
+static void find_default_streams( AVFormatContext *context, int *audio_index, int *video_index )
 {
        int i;
 
@@ -116,15 +108,43 @@ void find_default_streams( AVFormatContext *context, int *audio_index, int *vide
        }
 }
 
-/** Open the file.
+/** Producer file destructor.
+*/
 
-       NOTE: We need to have a valid [PAL or NTSC] frame rate before we can determine the 
-       number of frames in the file. However, this is at odds with the way things work - the 
-       constructor needs to provide in/out points before the user of the producer is able
-       to specify properties :-/. However, the PAL/NTSC distinction applies to all producers
-       and while we currently accept whatever the producer provides, this will not work in
-       the more general case. Plans are afoot... and this one will work without modification
-       (in theory anyway ;-)).
+static void producer_file_close( void *context )
+{
+       if ( context != NULL )
+       {
+               // Lock the mutex now
+               avformat_lock( );
+
+               // Close the file
+               av_close_input_file( context );
+
+               // Unlock the mutex now
+               avformat_unlock( );
+       }
+}
+
+/** Producer file destructor.
+*/
+
+static void producer_codec_close( void *codec )
+{
+       if ( codec != NULL )
+       {
+               // Lock the mutex now
+               avformat_lock( );
+
+               // Close the file
+               avcodec_close( codec );
+
+               // Unlock the mutex now
+               avformat_unlock( );
+       }
+}
+
+/** Open the file.
 */
 
 static int producer_open( mlt_producer this, char *file )
@@ -141,8 +161,91 @@ static int producer_open( mlt_producer this, char *file )
        // We will treat everything with the producer fps
        double fps = mlt_properties_get_double( properties, "fps" );
 
+       // Lock the mutex now
+       avformat_lock( );
+       
+       // If "MRL", then create AVInputFormat
+       AVInputFormat *format = NULL;
+       AVFormatParameters *params = NULL;
+       char *standard = NULL;
+       char *mrl = strchr( file, ':' );
+
+       // AV option (0 = both, 1 = video, 2 = audio)
+       int av = 0;
+       
+       // Only if there is not a protocol specification that avformat can handle
+       if ( mrl && !url_exist( file ) )
+       {
+               // 'file' becomes format abbreviation
+               mrl[0] = 0;
+       
+               // Lookup the format
+               format = av_find_input_format( file );
+               
+               // Eat the format designator
+               file = ++mrl;
+               
+               if ( format )
+               {
+                       // Allocate params
+                       params = calloc( sizeof( AVFormatParameters ), 1 );
+                       
+                       // These are required by video4linux (defaults)
+                       params->width = 640;
+                       params->height = 480;
+                       params->frame_rate = 25;
+                       params->frame_rate_base = 1;
+                       params->device = file;
+                       params->channels = 2;
+                       params->sample_rate = 48000;
+               }
+               
+               // Parse out params
+               mrl = strchr( file, '?' );
+               while ( mrl )
+               {
+                       mrl[0] = 0;
+                       char *name = strdup( ++mrl );
+                       char *value = strchr( name, ':' );
+                       if ( value )
+                       {
+                               value[0] = 0;
+                               value++;
+                               char *t = strchr( value, '&' );
+                               if ( t )
+                                       t[0] = 0;
+                               if ( !strcmp( name, "frame_rate" ) )
+                                       params->frame_rate = atoi( value );
+                               else if ( !strcmp( name, "frame_rate_base" ) )
+                                       params->frame_rate_base = atoi( value );
+                               else if ( !strcmp( name, "sample_rate" ) )
+                                       params->sample_rate = atoi( value );
+                               else if ( !strcmp( name, "channels" ) )
+                                       params->channels = atoi( value );
+                               else if ( !strcmp( name, "width" ) )
+                                       params->width = atoi( value );
+                               else if ( !strcmp( name, "height" ) )
+                                       params->height = atoi( value );
+                               else if ( !strcmp( name, "standard" ) )
+                               {
+                                       standard = strdup( value );
+                                       params->standard = standard;
+                               }
+                               else if ( !strcmp( name, "av" ) )
+                                       av = atoi( value );
+                       }
+                       free( name );
+                       mrl = strchr( mrl, '&' );
+               }
+       }
+
        // Now attempt to open the file
-       error = av_open_input_file( &context, file, NULL, 0, NULL ) < 0;
+       error = av_open_input_file( &context, file, format, 0, params );
+       error = error < 0;
+       
+       // Cleanup AVFormatParameters
+       free( standard );
+       free( params );
 
        // If successful, then try to get additional info
        if ( error == 0 )
@@ -162,39 +265,46 @@ static int producer_open( mlt_producer this, char *file )
                        {
                                // This isn't going to be accurate for all formats
                                mlt_position frames = ( mlt_position )( ( ( double )context->duration / ( double )AV_TIME_BASE ) * fps );
-                               mlt_properties_set_position( properties, "out", frames - 1 );
-                               mlt_properties_set_position( properties, "length", frames );
+                               mlt_properties_set_position( properties, "out", frames - 2 );
+                               mlt_properties_set_position( properties, "length", frames - 1 );
                        }
 
                        // Find default audio and video streams
                        find_default_streams( context, &audio_index, &video_index );
 
+            if ( context->start_time != AV_NOPTS_VALUE )
+                mlt_properties_set_double( properties, "start_time", context->start_time );
+                       
+                       // Check if we're seekable (something funny about mpeg here :-/)
+                       if ( strcmp( file, "pipe:" ) )
+                               mlt_properties_set_int( properties, "seekable", av_seek_frame( context, -1, mlt_properties_get_double( properties, "start_time" ) ) >= 0 );
+
                        // Store selected audio and video indexes on properties
                        mlt_properties_set_int( properties, "audio_index", audio_index );
                        mlt_properties_set_int( properties, "video_index", video_index );
-
+                       
                        // We're going to cheat here - for a/v files, we will have two contexts (reasoning will be clear later)
-                       if ( audio_index != -1 && video_index != -1 )
+                       if ( av == 0 && strcmp( file, "pipe:" ) && audio_index != -1 && video_index != -1 )
                        {
                                // We'll use the open one as our video_context
-                               mlt_properties_set_data( properties, "video_context", context, 0, ( mlt_destructor )av_close_input_file, NULL );
+                               mlt_properties_set_data( properties, "video_context", context, 0, producer_file_close, NULL );
 
                                // And open again for our audio context
                                av_open_input_file( &context, file, NULL, 0, NULL );
                                av_find_stream_info( context );
 
                                // Audio context
-                               mlt_properties_set_data( properties, "audio_context", context, 0, ( mlt_destructor )av_close_input_file, NULL );
+                               mlt_properties_set_data( properties, "audio_context", context, 0, producer_file_close, NULL );
                        }
-                       else if ( video_index != -1 )
+                       else if ( av != 2 && video_index != -1 )
                        {
                                // We only have a video context
-                               mlt_properties_set_data( properties, "video_context", context, 0, ( mlt_destructor )av_close_input_file, NULL );
+                               mlt_properties_set_data( properties, "video_context", context, 0, producer_file_close, NULL );
                        }
                        else if ( audio_index != -1 )
                        {
                                // We only have an audio context
-                               mlt_properties_set_data( properties, "audio_context", context, 0, ( mlt_destructor )av_close_input_file, NULL );
+                               mlt_properties_set_data( properties, "audio_context", context, 0, producer_file_close, NULL );
                        }
                        else
                        {
@@ -204,6 +314,9 @@ static int producer_open( mlt_producer this, char *file )
                }
        }
 
+       // Unlock the mutex now
+       avformat_unlock( );
+
        return error;
 }
 
@@ -270,7 +383,13 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
        int ignore = 0;
 
        // Current time calcs
-       double current_time = 0;
+       double current_time = mlt_properties_get_double( properties, "current_time" );
+
+       // We may want to use the source fps if available
+       double source_fps = mlt_properties_get_double( properties, "source_fps" );
+
+       // Get the seekable status
+       int seekable = mlt_properties_get_int( properties, "seekable" );
 
        // Set the result arguments that we know here (only *buffer is now required)
        *format = mlt_image_yuv422;
@@ -284,12 +403,12 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
        // Construct an AVFrame for YUV422 conversion
        if ( output == NULL )
        {
-               int size = avpicture_get_size( PIX_FMT_YUV422, *width, *height );
-               uint8_t *buf = malloc( size );
-               output = malloc( sizeof( AVPicture ) );
+               int size = avpicture_get_size( PIX_FMT_YUV422, *width, *height + 1 );
+               uint8_t *buf = mlt_pool_alloc( size );
+               output = mlt_pool_alloc( sizeof( AVPicture ) );
                avpicture_fill( output, buf, PIX_FMT_YUV422, *width, *height );
-               mlt_properties_set_data( properties, "video_output_frame", output, 0, av_free, NULL );
-               mlt_properties_set_data( properties, "video_output_buffer", buf, 0, free, NULL );
+               mlt_properties_set_data( properties, "video_output_frame", output, 0, ( mlt_destructor )mlt_pool_release, NULL );
+               mlt_properties_set_data( properties, "video_output_buffer", buf, 0, ( mlt_destructor )mlt_pool_release, NULL );
        }
 
        // Seek if necessary
@@ -300,36 +419,37 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
                        // We're paused - use last image
                        paused = 1;
                }
-               else if ( position > expected && ( position - expected ) < 250 )
+               else if ( !seekable && position > expected && ( position - expected ) < 250 )
                {
                        // Fast forward - seeking is inefficient for small distances - just ignore following frames
                        ignore = position - expected;
                }
-               else
+               else if ( codec_context->gop_size == 0 || ( position < expected || position - expected >= 12 ) )
                {
                        // Set to the real timecode
-                       av_seek_frame( context, -1, real_timecode * 1000000.0 );
+                       av_seek_frame( context, -1, mlt_properties_get_double( properties, "start_time" ) + real_timecode * 1000000.0 );
        
                        // Remove the cached info relating to the previous position
-                       mlt_properties_set_double( properties, "current_time", 0 );
+                       mlt_properties_set_double( properties, "current_time", real_timecode );
                        mlt_properties_set_data( properties, "current_image", NULL, 0, NULL, NULL );
                }
        }
        
        // Duplicate the last image if necessary
        if ( mlt_properties_get_data( properties, "current_image", NULL ) != NULL &&
-                ( paused || mlt_properties_get_double( properties, "current_time" ) > real_timecode ) )
+                ( paused || mlt_properties_get_double( properties, "current_time" ) >= real_timecode ) &&
+                strcmp( mlt_properties_get( properties, "resource" ), "pipe:" ) )
        {
                // Get current image and size
                int size = 0;
                uint8_t *image = mlt_properties_get_data( properties, "current_image", &size );
 
                // Duplicate it
-               *buffer = malloc( size );
+               *buffer = mlt_pool_alloc( size );
                memcpy( *buffer, image, size );
 
                // Set this on the frame properties
-               mlt_properties_set_data( frame_properties, "image", *buffer, size, free, NULL );
+               mlt_properties_set_data( frame_properties, "image", *buffer, size, ( mlt_destructor )mlt_pool_release, NULL );
        }
        else
        {
@@ -349,26 +469,32 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
                        if ( ret >= 0 && pkt.stream_index == index && pkt.size > 0 )
                        {
                                // Decode the image
-                               // Wouldn't it be great if I could use this...
-                               //if ( (float)pkt.pts / 1000000.0 >= real_timecode )
                                ret = avcodec_decode_video( codec_context, &frame, &got_picture, pkt.data, pkt.size );
 
-                               // Handle ignore
-                               if ( (float)pkt.pts / 1000000.0 < real_timecode )
+                               if ( got_picture )
                                {
-                                       ignore = 0;
-                                       got_picture = 0;
-                               }
-                               else if ( (float)pkt.pts / 1000000.0 >= real_timecode )
-                               {
-                                       ignore = 0;
-                               }
-                               else if ( got_picture && ignore -- )
-                               {
-                                       got_picture = 0;
-                               }
+                                       if ( pkt.pts != AV_NOPTS_VALUE )
+                                               current_time = ( double )pkt.pts / 1000000.0;
+                                       else
+                                               current_time = real_timecode;
 
-                               current_time = ( double )pkt.pts / 1000000.0;
+                                       // Handle ignore
+                                       if ( ( int )( current_time * 100 ) < ( int )( real_timecode * 100 ) - 7 )
+                                       {
+                                               ignore = 0;
+                                               got_picture = 0;
+                                       }
+                                       else if ( current_time >= real_timecode )
+                                       {
+                                               //current_time = real_timecode;
+                                               ignore = 0;
+                                       }
+                                       else if ( ignore -- )
+                                       {
+                                               got_picture = 0;
+                                       }
+                                       mlt_properties_set_int( properties, "top_field_first", frame.top_field_first );
+                               }
                        }
 
                        // We're finished with this packet regardless
@@ -384,19 +510,82 @@ static int producer_get_image( mlt_frame frame, uint8_t **buffer, mlt_image_form
 
                        if ( image == NULL || size != *width * *height * 2 )
                        {
-                               size = *width * *height * 2;
-                               image = malloc( size );
-                               mlt_properties_set_data( properties, "current_image", image, size, free, NULL );
+                               size = *width * ( *height + 1 ) * 2;
+                               image = mlt_pool_alloc( size );
+                               mlt_properties_set_data( properties, "current_image", image, size, ( mlt_destructor )mlt_pool_release, NULL );
                        }
 
-                       *buffer = malloc( size );
-                       img_convert( output, PIX_FMT_YUV422, (AVPicture *)&frame, codec_context->pix_fmt, *width, *height );
-                       memcpy( image, output->data[ 0 ], size );
-                       memcpy( *buffer, output->data[ 0 ], size );
-                       mlt_properties_set_data( frame_properties, "image", *buffer, size, free, NULL );
-                       mlt_properties_set_double( properties, "current_time", current_time );
+                       *buffer = mlt_pool_alloc( size );
+
+                       // EXPERIMENTAL IMAGE NORMALISATIONS
+                       if ( codec_context->pix_fmt == PIX_FMT_YUV420P )
+                       {
+                               register int i, j;
+                               register int half = *width >> 1;
+                               register uint8_t *Y = ( ( AVPicture * )&frame )->data[ 0 ];
+                               register uint8_t *U = ( ( AVPicture * )&frame )->data[ 1 ];
+                               register uint8_t *V = ( ( AVPicture * )&frame )->data[ 2 ];
+                               register uint8_t *d = *buffer;
+                               register uint8_t *y, *u, *v;
+
+                               i = *height >> 1;
+                               while ( i -- )
+                               {
+                                       y = Y;
+                                       u = U;
+                                       v = V;
+                                       j = half;
+                                       while ( j -- )
+                                       {
+                                               *d ++ = *y ++;
+                                               *d ++ = *u ++;
+                                               *d ++ = *y ++;
+                                               *d ++ = *v ++;
+                                       }
+
+                                       Y += ( ( AVPicture * )&frame )->linesize[ 0 ];
+                                       y = Y;
+                                       u = U;
+                                       v = V;
+                                       j = half;
+                                       while ( j -- )
+                                       {
+                                               *d ++ = *y ++;
+                                               *d ++ = *u ++;
+                                               *d ++ = *y ++;
+                                               *d ++ = *v ++;
+                                       }
+
+                                       Y += ( ( AVPicture * )&frame )->linesize[ 0 ];
+                                       U += ( ( AVPicture * )&frame )->linesize[ 1 ];
+                                       V += ( ( AVPicture * )&frame )->linesize[ 2 ];
+                               }
+                       }
+                       else
+                       {
+                               img_convert( output, PIX_FMT_YUV422, (AVPicture *)&frame, codec_context->pix_fmt, *width, *height );
+                               memcpy( *buffer, output->data[ 0 ], size );
+                       }
+
+                       memcpy( image, *buffer, size );
+                       mlt_properties_set_data( frame_properties, "image", *buffer, size, ( mlt_destructor )mlt_pool_release, NULL );
+
+                       if ( current_time == 0 && source_fps != 0 )
+                       {
+                               double fps = mlt_properties_get_double( properties, "fps" );
+                               current_time = ceil( source_fps * ( double )position / fps ) * ( 1 / source_fps );
+                               mlt_properties_set_double( properties, "current_time", current_time );
+                       }
+                       else
+                       {
+                               mlt_properties_set_double( properties, "current_time", current_time );
+                       }
                }
        }
+       
+       // Set the field order property for this frame
+       mlt_properties_set_int( frame_properties, "top_field_first", 
+               mlt_properties_get_int( properties, "top_field_first" ) );
 
        // Regardless of speed, we expect to get the next frame (cos we ain't too bright)
        mlt_properties_set_position( properties, "video_expected", position + 1 );
@@ -418,11 +607,11 @@ static void producer_set_up_video( mlt_producer this, mlt_frame frame )
        // Get the video_index
        int index = mlt_properties_get_int( properties, "video_index" );
 
+       // Get the frame properties
+       mlt_properties frame_properties = mlt_frame_properties( frame );
+
        if ( context != NULL && index != -1 )
        {
-               // Get the frame properties
-               mlt_properties frame_properties = mlt_frame_properties( frame );
-
                // Get the video stream
                AVStream *stream = context->streams[ index ];
 
@@ -441,24 +630,8 @@ static void producer_set_up_video( mlt_producer this, mlt_frame frame )
                        // If we don't have a codec and we can't initialise it, we can't do much more...
                        if ( codec != NULL && avcodec_open( codec_context, codec ) >= 0 )
                        {
-                               double aspect_ratio = 0;
-
-                               // Set aspect ratio
-                               if ( codec_context->sample_aspect_ratio.num == 0) 
-                                       aspect_ratio = 0;
-                               else
-                                       aspect_ratio = av_q2d( codec_context->sample_aspect_ratio ) * codec_context->width / codec_context->height;
-
-                       if (aspect_ratio <= 0.0)
-                                       aspect_ratio = ( double )codec_context->width / ( double )codec_context->height;
-
-                               mlt_properties_set_double( properties, "aspect_ratio", aspect_ratio );
-
                                // Now store the codec with its destructor
-                               mlt_properties_set_data( properties, "video_codec", codec, 0, ( mlt_destructor )avcodec_close, NULL );
-
-                               // Set to the real timecode
-                               av_seek_frame( context, -1, 0 );
+                               mlt_properties_set_data( properties, "video_codec", codec_context, 0, producer_codec_close, NULL );
                        }
                        else
                        {
@@ -470,9 +643,45 @@ static void producer_set_up_video( mlt_producer this, mlt_frame frame )
                // No codec, no show...
                if ( codec != NULL )
                {
+                       double source_fps = 0;
+
+                       // XXX: We won't know the real aspect ratio until an image is decoded
+                       // but we do need it now (to satisfy filter_resize) - take a guess based
+                       // on pal/ntsc
+                       if ( codec_context->sample_aspect_ratio.num > 0 )
+                       {
+                               mlt_properties_set_double( properties, "aspect_ratio", av_q2d( codec_context->sample_aspect_ratio ) );
+                       }
+                       else
+                       {
+                               int is_pal = mlt_properties_get_double( properties, "fps" ) == 25.0;
+                               mlt_properties_set_double( properties, "aspect_ratio", is_pal ? 128.0/117.0 : 72.0/79.0 );
+                       }
+
+                       //fprintf( stderr, "AVFORMAT: sample aspect %f %dx%d\n", av_q2d( codec_context->sample_aspect_ratio ), codec_context->width, codec_context->height );
+
+                       // Determine the fps
+                       source_fps = ( double )codec_context->frame_rate / ( codec_context->frame_rate_base == 0 ? 1 : codec_context->frame_rate_base );
+
+                       // We'll use fps if it's available
+                       if ( source_fps > 0 && source_fps < 30 )
+                               mlt_properties_set_double( properties, "source_fps", source_fps );
+                       
+                       // Set the width and height
+                       mlt_properties_set_int( frame_properties, "width", codec_context->width );
+                       mlt_properties_set_int( frame_properties, "height", codec_context->height );
+
                        mlt_frame_push_get_image( frame, producer_get_image );
                        mlt_properties_set_data( frame_properties, "avformat_producer", this, 0, NULL, NULL );
                }
+               else
+               {
+                       mlt_properties_set_int( frame_properties, "test_image", 1 );
+               }
+       }
+       else
+       {
+               mlt_properties_set_int( frame_properties, "test_image", 1 );
        }
 }
 
@@ -499,6 +708,9 @@ static int producer_get_audio( mlt_frame frame, int16_t **buffer, mlt_audio_form
        // Get the audio_index
        int index = mlt_properties_get_int( properties, "audio_index" );
 
+       // Get the seekable status
+       int seekable = mlt_properties_get_int( properties, "seekable" );
+
        // Obtain the expected frame numer
        mlt_position expected = mlt_properties_get_position( properties, "audio_expected" );
 
@@ -530,23 +742,28 @@ static int producer_get_audio( mlt_frame frame, int16_t **buffer, mlt_audio_form
        int paused = 0;
 
        // Check for resample and create if necessary
-       if ( resample == NULL )
+       if ( resample == NULL && codec_context->channels <= 2 )
        {
                // Create the resampler
                resample = audio_resample_init( *channels, codec_context->channels, *frequency, codec_context->sample_rate );
 
                // And store it on properties
-               mlt_properties_set_data( properties, "audio_resample", resample, 0, ( mlt_destructor ) audio_resample_close, NULL );
+               mlt_properties_set_data( properties, "audio_resample", resample, 0, ( mlt_destructor )audio_resample_close, NULL );
+       }
+       else if ( resample == NULL )
+       {
+               *channels = codec_context->channels;
+               *frequency = codec_context->sample_rate;
        }
 
        // Check for audio buffer and create if necessary
        if ( audio_buffer == NULL )
        {
                // Allocate the audio buffer
-               audio_buffer = malloc( AVCODEC_MAX_AUDIO_FRAME_SIZE * sizeof( int16_t ) );
+               audio_buffer = mlt_pool_alloc( AVCODEC_MAX_AUDIO_FRAME_SIZE * sizeof( int16_t ) );
 
                // And store it on properties for reuse
-               mlt_properties_set_data( properties, "audio_buffer", audio_buffer, 0, free, NULL );
+               mlt_properties_set_data( properties, "audio_buffer", audio_buffer, 0, ( mlt_destructor )mlt_pool_release, NULL );
        }
 
        // Seek if necessary
@@ -557,15 +774,16 @@ static int producer_get_audio( mlt_frame frame, int16_t **buffer, mlt_audio_form
                        // We're paused - silence required
                        paused = 1;
                }
-               else if ( position > expected && ( position - expected ) < 250 )
+               else if ( !seekable && position > expected && ( position - expected ) < 250 )
                {
                        // Fast forward - seeking is inefficient for small distances - just ignore following frames
                        ignore = position - expected;
                }
-               else
+               else if ( position < expected || position - expected >= 12 )
                {
                        // Set to the real timecode
-                       av_seek_frame( context, -1, real_timecode * 1000000.0 );
+                       if ( av_seek_frame( context, -1, mlt_properties_get_double( properties, "start_time" ) + real_timecode * 1000000.0 ) != 0 )
+                               paused = 1;
 
                        // Clear the usage in the audio buffer
                        audio_used = 0;
@@ -577,7 +795,7 @@ static int producer_get_audio( mlt_frame frame, int16_t **buffer, mlt_audio_form
        {
                int ret = 0;
                int got_audio = 0;
-               int16_t temp[ AVCODEC_MAX_AUDIO_FRAME_SIZE / 2 ];
+               int16_t *temp = mlt_pool_alloc( sizeof( int16_t ) * AVCODEC_MAX_AUDIO_FRAME_SIZE );
 
                memset( &pkt, 0, sizeof( pkt ) );
 
@@ -597,26 +815,32 @@ static int producer_get_audio( mlt_frame frame, int16_t **buffer, mlt_audio_form
                uint8_t *ptr = pkt.data;
                        int data_size;
 
-                       if ( ptr == NULL || len == 0 )
-                               break;
-
-                       // We only deal with video from the selected video_index
-                       while ( ret >= 0 && pkt.stream_index == index && len > 0 )
+                       // We only deal with audio from the selected audio_index
+                       while ( ptr != NULL && ret >= 0 && pkt.stream_index == index && len > 0 )
                        {
                                // Decode the audio
                                ret = avcodec_decode_audio( codec_context, temp, &data_size, ptr, len );
 
                                if ( ret < 0 )
+                               {
+                                       ret = 0;
                                        break;
+                               }
 
                                len -= ret;
                                ptr += ret;
 
                                if ( data_size > 0 )
                                {
-                                       int size_out = audio_resample( resample, &audio_buffer[ audio_used * *channels ], temp, data_size / ( codec_context->channels * sizeof( int16_t ) ) );
-
-                                       audio_used += size_out;
+                                       if ( resample != NULL )
+                                       {
+                                               audio_used += audio_resample( resample, &audio_buffer[ audio_used * *channels ], temp, data_size / ( codec_context->channels * sizeof( int16_t ) ) );
+                                       }
+                                       else
+                                       {
+                                               memcpy( &audio_buffer[ audio_used * *channels ], temp, data_size );
+                                               audio_used += data_size / ( codec_context->channels * sizeof( int16_t ) );
+                                       }
 
                                        // Handle ignore
                                        while ( ignore && audio_used > *samples )
@@ -629,10 +853,7 @@ static int producer_get_audio( mlt_frame frame, int16_t **buffer, mlt_audio_form
 
                                // If we're behind, ignore this packet
                                float current_pts = (float)pkt.pts / 1000000.0;
-                               double discrepancy = mlt_properties_get_double( properties, "discrepancy" );
-
-                               fprintf( stderr, "%f < %f\n", discrepancy * current_pts, (float) real_timecode );
-                               if ( discrepancy * current_pts < real_timecode )
+                               if ( seekable && ( !ignore && current_pts <= ( real_timecode - 0.02 ) ) )
                                        ignore = 1;
                        }
 
@@ -640,24 +861,26 @@ static int producer_get_audio( mlt_frame frame, int16_t **buffer, mlt_audio_form
                        av_free_packet( &pkt );
                }
 
+               *buffer = mlt_pool_alloc( *samples * *channels * sizeof( int16_t ) );
+               mlt_properties_set_data( frame_properties, "audio", *buffer, 0, ( mlt_destructor )mlt_pool_release, NULL );
+
                // Now handle the audio if we have enough
                if ( audio_used >= *samples )
                {
-                       *buffer = malloc( *samples * *channels * sizeof( int16_t ) );
                        memcpy( *buffer, audio_buffer, *samples * *channels * sizeof( int16_t ) );
                        audio_used -= *samples;
                        memmove( audio_buffer, &audio_buffer[ *samples * *channels ], audio_used * *channels * sizeof( int16_t ) );
-                       mlt_properties_set_data( frame_properties, "audio", *buffer, 0, free, NULL );
                }
                else
                {
-                       frame->get_audio = NULL;
-                       mlt_frame_get_audio( frame, buffer, format, frequency, channels, samples );
-                       audio_used = 0;
+                       memset( *buffer, 0, *samples * *channels * sizeof( int16_t ) );
                }
                
                // Store the number of audio samples still available
                mlt_properties_set_int( properties, "audio_used", audio_used );
+
+               // Release the temporary audio
+               mlt_pool_release( temp );
        }
        else
        {
@@ -666,8 +889,9 @@ static int producer_get_audio( mlt_frame frame, int16_t **buffer, mlt_audio_form
                mlt_frame_get_audio( frame, buffer, format, frequency, channels, samples );
        }
 
-       // Regardless of speed, we expect to get the next frame (cos we ain't too bright)
-       mlt_properties_set_position( properties, "audio_expected", position + 1 );
+       // Regardless of speed (other than paused), we expect to get the next frame
+       if ( !paused )
+               mlt_properties_set_position( properties, "audio_expected", position + 1 );
 
        return 0;
 }
@@ -711,7 +935,8 @@ static void producer_set_up_audio( mlt_producer this, mlt_frame frame )
                        if ( codec != NULL && avcodec_open( codec_context, codec ) >= 0 )
                        {
                                // Now store the codec with its destructor
-                               mlt_properties_set_data( properties, "audio_codec", codec, 0, ( mlt_destructor )avcodec_close, NULL );
+                               mlt_properties_set_data( properties, "audio_codec", codec_context, 0, producer_codec_close, NULL );
+
                        }
                        else
                        {
@@ -741,7 +966,7 @@ static int producer_get_frame( mlt_producer this, mlt_frame_ptr frame, int index
        mlt_frame_set_position( *frame, mlt_producer_position( this ) );
 
        // Set the position of this producer
-       mlt_properties_set_position( mlt_frame_properties( *frame ), "avformat_position", mlt_producer_get_in( this ) + mlt_producer_position( this ) );
+       mlt_properties_set_position( mlt_frame_properties( *frame ), "avformat_position", mlt_producer_position( this ) );
 
        // Set up the video
        producer_set_up_video( this, *frame );